Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Metal Backend #969

Merged
merged 19 commits into from Jul 28, 2016

Conversation

@fkaa
Copy link
Member

commented May 9, 2016

Done:

  • gfx_window_metal
  • Metal backend in gfx_app
  • PSO
  • Reflection
  • Texture/Samplers
  • Command buffer/encoder
  • Depth/stencil things

Almost done:

  • Bunch of factory methods for updating data etc.

Not started:

  • Instancing
  • Fixing memory leaks – the thing i'm looking forward to the least (i'm saving .retain(), .release() for last)

Probably bunch of other stuff i missed mentioning, but should crop up eventually

@fkaa

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

We have clear color now 🔨

clear

@bvssvni

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

Can you rebase? I want to try it on my computer.

@fkaa

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

@bvssvni that should do it! (Only the cube example "works" at the moment though)

@bvssvni

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

I'm getting this error:

src/backend/metal/src/command.rs:68:1: 68:30 error: the trait `Copy` may not be implemented for this type; variant `SetViewport` does not implement `Copy` [E0205]
src/backend/metal/src/command.rs:68 #[derive(Clone, Copy, Debug)]
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@fkaa

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

Sorry, was working with local cargo override. Pushed the changes now.

@bvssvni

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

@fkaa Still getting same error.

@fkaa

This comment has been minimized.

Copy link
Member Author

commented May 19, 2016

cargo update -p metal?

@bvssvni

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

@fkaa Yay! It works!

@fkaa

This comment has been minimized.

Copy link
Member Author

commented May 28, 2016

We have cube!
cube

@fkaa fkaa force-pushed the fkaa:metal branch from 17d7b0a to 7a3d257 Jul 28, 2016

@kvark

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

Thanks @fkaa! Proceeding with merge.
The biggest problem here would be supporting the code base, given that it grows faster than our contributor base.

@kvark

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

@homu r+

@homu

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2016

📌 Commit 7a3d257 has been approved by kvark

@homu homu merged commit 7a3d257 into gfx-rs:master Jul 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu added a commit that referenced this pull request Jul 28, 2016

Auto merge of #969 - fkaa:metal, r=kvark
[WIP] Metal Backend

#### Done:
* `gfx_window_metal`
* Metal backend in `gfx_app`
* PSO
* Reflection
* Texture/Samplers
* Command buffer/encoder
* Depth/stencil things

#### Almost done:
* Bunch of factory methods for updating data etc.

#### Not started:
* Instancing
* Fixing memory leaks – the thing i'm looking forward to the least (i'm saving `.retain()`, `.release()` for last)

Probably bunch of other stuff i missed mentioning, but should crop up eventually
@homu

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2016

⚡️ Test exempted - status

@kvark

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

@fkaa was able to get the shadow example kinda working with some tweaking:
shadow example
The backend is not ready for adoption, but it's getting close to it!

@kvark kvark referenced this pull request Jul 28, 2016

Closed

Metal backend #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.