Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Android / GLES support #993

Merged
merged 13 commits into from Jun 22, 2016

Conversation

@kvark
Copy link
Member

commented Jun 15, 2016

Closes #160 (basic support, more fixes might be needed later on)

Note: a side effect of this PR is a requirement of GL-3.2 for the example launcher. Glutin needs to be augmented in order to make this more flexible. GFX itself can still work with GL-2.1 though.

Image from @ozkriff:
Android triangle

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2016

To make this more complete, we need GLES support to gfx_app, so that the examples (or at least some of them) could be run out of the box.

@fkaa

This comment has been minimized.

Copy link
Member

commented Jun 18, 2016

@kvark does it require a new backend or can it run on the OpenGL one with Capabilities restricting it to GLES features?

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2016

No, it's the same backend, fortunately :)

On Jun 18, 2016, at 9:58, Felix Kaaman notifications@github.com wrote:

@kvark does it require a new backend or can it run on the OpenGL one with Capabilities restricting it to GLES features?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@kvark kvark changed the title [gl] basic GLES version check Basic Android / GLES support Jun 19, 2016

@kvark kvark force-pushed the kvark-android branch from ca9224e to 821be1d Jun 19, 2016

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2016

Ok, I got the cube example working with the example launcher without any modifications now. I consider Android/ES done, at least for now. Feel free to add more features in other PRs!

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2016

@csherratt review again please?

@ghost

This comment has been minimized.

Copy link

commented Jun 21, 2016

Looks good! This looks ready to merge, if there is anything else I can put hold off.

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2016

@homu r=csherratt

@ghost

This comment has been minimized.

Copy link

commented Jun 21, 2016

@homu r+

@kvark kvark merged commit 3f9d2f5 into master Jun 22, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kvark kvark deleted the kvark-android branch Jun 22, 2016

@homu homu referenced this pull request Jun 22, 2016

Merged

Vulkan backend (first steps) #983

4 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.