Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-in] sign() incorrectly does not accept i32 arguments #2458

Closed
Andrewp2 opened this issue Aug 28, 2023 · 0 comments · Fixed by #2463
Closed

[wgsl-in] sign() incorrectly does not accept i32 arguments #2458

Andrewp2 opened this issue Aug 28, 2023 · 0 comments · Fixed by #2463
Labels
area: validation Validation of the IR kind: bug Something isn't working
Milestone
WGSL Specificatio...

Comments

@Andrewp2
Copy link

I believe the issue is right here:

naga/src/valid/expression.rs

Line 979 in 6aca2e2

| Mf::Sign

Sign can accept i32s per the WGSL spec: https://www.w3.org/TR/WGSL/#sign-builtin
@Andrewp2 Andrewp2 changed the title sign() incorrectly does not accept i32 arguments (WGSL) [wgsl-in] sign() incorrectly does not accept i32 arguments Aug 28, 2023
@teoxoy teoxoy added kind: bug Something isn't working area: validation Validation of the IR labels Aug 31, 2023
@teoxoy teoxoy added this to the WGSL Specification V1 milestone Aug 31, 2023
@fornwall fornwall mentioned this issue Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: validation Validation of the IR kind: bug Something isn't working
Projects
None yet
Milestone
WGSL Specification V1
Development

Successfully merging a pull request may close this issue.

[wgsl-in] Allow sign() to take int argument fornwall/naga
2 participants
@Andrewp2 @teoxoy