Removed erroneous zero size check related conditional in water example resize() #534
Conversation
…on the zero width and height condition. The conditional removed here was then getting run on every other call to resize(), which doesn't seem logical, doesn't correspond to the comment, and seemed to be causing at least one issue with rendered viewport going black during resize. Fixes #532 (probably) Fixes #519
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 0 warnings, 2 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
…ero, e.g. NaN being passed in cgmath::perspective() aspect ratio parameter. Fixes #531
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 0 warnings, 2 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
|
I'm thinking that a proper application would not even try to create a swapchain when it's minimized. It serves no use. It should not try to render anything. |
The conditional at the start of resize() already tests for and exits on the zero width and height condition.
The conditional removed here was then getting run on every other call to resize(), which doesn't seem logical, doesn't correspond to the comment, and seemed to be causing at least one issue with rendered viewport going black during resize.
Fixes #532
(probably) Fixes #519