Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failure when using Metal GPU capture #1879

Closed
schell opened this issue Aug 29, 2021 · 2 comments · Fixed by #5137
Closed

Assertion failure when using Metal GPU capture #1879

schell opened this issue Aug 29, 2021 · 2 comments · Fixed by #5137
Labels
area: correctness We're behaving incorrectly
Milestone
WebGPU Specificat...

Comments

@schell
Copy link
Contributor

schell commented Aug 29, 2021

Description
While trying to take a GPU capture in Xcode I'm encountering an assertion failure:

-[MTLDebugRenderCommandEncoder validateCommonDrawErrors:instanceCount:baseInstance:maxVertexID:]:4185: failed assertion `instanceCount(0) must be non-zero.'

Platform
macos 11.5.2 (20G95)
wgpu 0.10.1
@schell schell changed the title Assertion failure when using Metal GPU caputer Assertion failure when using Metal GPU capture Aug 29, 2021
@kvark kvark added the area: correctness We're behaving incorrectly label Aug 29, 2021
@schell
Copy link
Contributor Author

schell commented Aug 29, 2021 •
edited

Turns out this is valid, Not sure if this should be supported, but I was using 0..0 as the instance range in RenderPass::draw.

@schell schell closed this as completed Aug 29, 2021
@schell schell reopened this Aug 29, 2021
@kvark
Copy link
Member

kvark commented Aug 29, 2021

We should support this, just ignoring the call if there are 0 intances.

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 5, 2022
@nical nical mentioned this issue Jan 24, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: correctness We're behaving incorrectly
Projects
None yet
Milestone
WebGPU Specification V1
Development

Successfully merging a pull request may close this issue.

Discard draws when the instance/vertex/index count is zero nical/wgpu
3 participants
@schell @kvark @teoxoy