Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upShadow example #71
Conversation
kvark
added some commits
Feb 22, 2019
kvark
requested a review
from grovesNL
Feb 22, 2019
This comment has been minimized.
This comment has been minimized.
|
Nailed the issue: our Vulkan-targeting GLSL should be outputting the depth in range 0 to 1, unlike what cgmath-rs projections are currently producing. See rustgd/cgmath#449
|
kvark
marked this pull request as ready for review
Feb 22, 2019
kvark
added some commits
Feb 22, 2019
kvark
force-pushed the
kvark:shadow
branch
from
7309d3d
to
cfe3da1
Feb 22, 2019
| #[no_mangle] | ||
| pub extern "C" fn wgpu_device_destroy(device_id: BufferId) { | ||
| HUB.devices.unregister(device_id); | ||
| } |
This comment has been minimized.
This comment has been minimized.
| @@ -123,5 +123,6 @@ pub fn run<E: Example>(title: &str) { | |||
|
|
|||
| let frame = swap_chain.get_next_texture(); | |||
| example.render(&frame, &mut device); | |||
| running &= !cfg!(feature = "metal-auto-capture"); | |||
This comment has been minimized.
This comment has been minimized.
bors bot
added a commit
that referenced
this pull request
Feb 23, 2019
This comment has been minimized.
This comment has been minimized.
Build succeeded |
bors
bot
merged commit 616a3dd
into
gfx-rs:master
Feb 23, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks!
The auto-capture thing was needed as a workaround for debugging while our presentation was broken. Now, one frame is captured automatically even without it, but the option is useful for compute.
… On Feb 23, 2019, at 02:56, bors[bot] ***@***.***> wrote:
Build succeeded
continuous-integration/travis-ci/push
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
kvark
deleted the
kvark:shadow
branch
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kvark commentedFeb 22, 2019
•
edited
I believe all the nuts and bolts are in place, just figuring out some details of making the shadow match between the rendering and sampling (hence the WIP).Most importantly, this PR includes crucial fixes and improvements of our resource tracking, plus a few fixes in the bind group and texture creation code.