Fix against Perl 5.19 #1

Merged
merged 2 commits into from May 6, 2014

Conversation

Projects
None yet
2 participants
Contributor

tomhukins commented May 6, 2014

Data::Clone doesn't work with Perl 5.19, soon to be released as Perl 5.20.

This branch fixes that problem and also fixes a spelling mistake.

tomhukins added some commits Apr 29, 2014

@tomhukins tomhukins Handle stack reallocation in callbacks
This patch was submitted by Father Chrysostomos in
https://rt.cpan.org/Ticket/Display.html?id=92570

ST expands to something referencing PL_stack_base. Since the order of
evalution of a=b is undefined in C, the value of PL_stack_base may be
read before sv_clone is called. sv_clone may reallocate the stack, so
the value gets written to freed memory and clone() returns its argument
instead of the clone.
d2e3442
@tomhukins tomhukins Fix a typo c6943a2
Owner

gfx commented May 6, 2014

Good catch! Thanks ;)

@gfx gfx added a commit that referenced this pull request May 6, 2014

@gfx gfx Merge pull request #1 from tomhukins/fixes
Fix against Perl 5.19
7a83dcd

@gfx gfx merged commit 7a83dcd into gfx:master May 6, 2014

@gfx gfx added a commit that referenced this pull request May 6, 2014

@gfx gfx Checking in changes prior to tagging of version 0.004.
Changelog diff is:

diff --git a/Changes b/Changes
index 50fc89c..1651761 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
 Revision history for Perl extension Data::Clone

+0.004 2014-05-07 06:58:25+0900
+    - Fix against Perl 5.19 (#1, by tomhukins)
+
 0.003 2011-01-15 23:02:18
     - Cloning normal object died as of 0.002, but it seems too strict
4910c1a
Owner

gfx commented May 6, 2014

Released 0.004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment