Skip to content

/ggez

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate `Conf` for `ContextBuilder`? #429

Closed
icefoxen opened this issue Jul 11, 2018 · 3 comments

Comments

@icefoxen
Copy link
Contributor

commented Jul 11, 2018

They do the same thing, but I feel like ContextBuilder does them more nicely.

@icefoxen icefoxen added this to the 0.5 milestone Jul 11, 2018

@icefoxen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 13, 2018

After some thought, we need Conf to still exist 'cause it's what is written for config files, and that might be useful, but we should make ContextBuilder the dominant pattern. This mainly just is some minor API updates and a lot of doc and example stuff.

@icefoxen icefoxen added enhancement *GOOD FIRST ISSUE* Type-CODE Type-DOCS labels Jul 13, 2018

icefoxen added a commit that referenced this issue Jul 14, 2018

@icefoxen
Updated all examples to use ContextBuilder. 
Working on issue #429.  Not finished, but progress has
been made.
Loading status checks…
d26fcf7
@icefoxen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 15, 2018

Should Context::load_from_conf() be marked deprecated???
@icefoxen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 2, 2018

Or just removed entirely! Done in a945294.

@icefoxen icefoxen closed this Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
*GOOD FIRST ISSUE* Type-CODE Type-DOCS enhancement
Projects
None yet
Milestone
  0.5
1 participant
@icefoxen
You can’t perform that action at this time.