Skip to content

/ggez

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we get rid of `graphics::rectangle()` and friends? #466

Closed
icefoxen opened this issue Aug 22, 2018 · 2 comments

Comments

@icefoxen
Copy link
Contributor

commented Aug 22, 2018

They're redundant to the Mesh builder functions, and everyone always uses them and then wonders why they're slow.

Are they more trouble than they're worth?

@icefoxen icefoxen added the question label Aug 22, 2018

@icefoxen icefoxen added this to the 0.5 milestone Aug 22, 2018

@ozkriff

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 22, 2018 •
edited

If there's no easy way to cache and reuse temporary meshes then it sounds totally reasonable to me.

new_circle(...).draw(...) isn't much worse than just circle(...) if someone really needs this behavior - and they'll make a conscious decision to do this.
@icefoxen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 13, 2018

Sounds like we should just pull the trigger on that then.

@icefoxen icefoxen added enhancement *GOOD FIRST ISSUE* Type-CODE and removed question labels Sep 13, 2018

icefoxen added a commit that referenced this issue Sep 22, 2018

@icefoxen
Yank out `graphics::rectangle()` and friends. 
Resolves issue #466.
Loading status checks…
80a0b51

@icefoxen icefoxen closed this Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
*GOOD FIRST ISSUE* Type-CODE enhancement
Projects
None yet
Milestone
  0.5
2 participants
@icefoxen @ozkriff
You can’t perform that action at this time.