Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameError in 0.5 is no longer sync. #566

Open
joetsoi opened this Issue Jan 27, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@joetsoi
Copy link

joetsoi commented Jan 27, 2019

This is because glutin::CreationError is !Sync http://docs.piston.rs/conrod/glutin/enum.CreationError.html#synthetic-implementations

this is all quite new to me, so take everything I say with a grain of salt, but I think GameError should be Sync https://rust-lang-nursery.github.io/api-guidelines/interoperability.html#error-types-are-meaningful-and-well-behaved-c-good-err

In my case I'm just drawing a rectangle, which I don't think has any change of raising a CreationError. So it'd be great if we made this a special case and separated it out? I know this is more an issue for glutin but it affects any thing that uses gameerror expecting Sync

This means you can't use ggez together with failure.

@joetsoi joetsoi changed the title `GameError` in 0.5 is no longer sync. GameError in 0.5 is no longer sync. Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.