Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.5 feedback) There're still some non-mint types in the API #568

Open
ozkriff opened this Issue Jan 28, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@ozkriff
Copy link
Contributor

ozkriff commented Jan 28, 2019

They can be found with: https://docs.rs/ggez/0.5.0-rc.0/ggez/?search=Point2 and https://docs.rs/ggez/0.5.0-rc.0/ggez/?search=Matrix4 :

  • ggez::graphics::Rect::point (field and getter)
  • ggez::graphics::Rect::move_to
  • ggez::graphics::Rect::contains

  • ggez::input::mouse::position
  • ggez::input::mouse::set_position
  • ggez::input::mouse::delta

  • ggez::graphics::mul_transform
  • ggez::graphics::set_transform
  • ggez::graphics::mul_projection
  • ggez::graphics::push_transform
  • ggez::graphics::set_projection
  • ggez::graphics::DrawParam::to_matrix
  • ggez::graphics::transform
  • ggez::graphics::projection

Related to #344

@ozkriff ozkriff changed the title (0.5.0-rc.0 feedback) There're still some non-mint types in the API (0.5 feedback) There're still some non-mint types in the API Jan 28, 2019

@icefoxen icefoxen added this to the 0.5 milestone Feb 5, 2019

icefoxen added a commit that referenced this issue Feb 14, 2019

Start removing stray nalgebra types from public API
See issue #568 for the list.  This one cleans up `graphics`,
I think.
@icefoxen

This comment has been minimized.

Copy link
Contributor

icefoxen commented Feb 19, 2019

Should be fixed but needs verification.

@ozkriff

This comment has been minimized.

Copy link
Contributor Author

ozkriff commented Feb 20, 2019

Still exposed nalgebra types that I've found in c7aa420:

  • set_transform
  • transform
  • DrawParam::to_matrix
  • DrawParam: dest, scale, offset
@icefoxen

This comment has been minimized.

Copy link
Contributor

icefoxen commented Feb 20, 2019

Yeah not sure what to do about the innards of DrawParam now that they're exposed to the outside world again. Or I wasn't sure last night. Now that it's a new day and I'm basically snowed in, it's obvious they should be mint types 'cause if we leave them as nalgebra types then anyone who touches them has to use the exact same version of nalgebra that ggez does.

That's gonna be annoying. Oh well.

@icefoxen

This comment has been minimized.

Copy link
Contributor

icefoxen commented Feb 24, 2019

Should be fixed... again.

@icefoxen

This comment has been minimized.

Copy link
Contributor

icefoxen commented Mar 10, 2019

@ozkriff Can you confirm? You seem to be better at actually finding these details than I. XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.