Skip to content

/ggez

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump max number of vertices in meshbuilder to u32 #574

Closed
icefoxen opened this issue Feb 4, 2019 · 1 comment

Comments

@icefoxen
Copy link
Contributor

commented Feb 4, 2019

Lyon has an option to handle it now.

@icefoxen icefoxen added *GOOD FIRST ISSUE* Type-CODE enhancement labels Feb 5, 2019

@icefoxen icefoxen added this to the 0.5 milestone Feb 5, 2019

@icefoxen icefoxen referenced this issue Feb 6, 2019

Closed

Use of u16 indices causes `attempt to subtract with overflow` panic #576

@icefoxen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Feb 6, 2019

See #576, the original Lyon bug report at nical/lyon#440 , especially nical's suggestion at the end of having ggez check and notice when the index overflows rather than having it panic in lyon. See nical/lyon#443 for tracking on that issue, but we might be able to detect even without needing that change.

@icefoxen icefoxen closed this in 591b045 Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
*GOOD FIRST ISSUE* Type-CODE enhancement
Projects
None yet
Milestone
  0.5
1 participant
@icefoxen
You can’t perform that action at this time.