Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the generic argument from Drawable::draw #559

Merged
merged 1 commit into from Jan 18, 2019

Conversation

@ozkriff
Copy link
Contributor

@ozkriff ozkriff commented Jan 18, 2019

Closes #556

Un-nested mesh creation calls because of the conflicting ctx arguments:

227 |         graphics::draw(
    |         -------------- first borrow later used by call
228 |             ctx,
    |             --- first mutable borrow occurs here
229 |             &graphics::Mesh::new_rectangle(ctx, graphics::DrawMode::Fill, self.pos.into(), color)?,
    |                                            ^^^ second mutable borrow occurs here

What do you think?

@icefoxen icefoxen merged commit 60cfa61 into ggez:master Jan 18, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ozkriff ozkriff deleted the ozkriff:i556_drawable_trait_object branch Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants