Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Text::dimensions height #593

Merged
merged 1 commit into from Feb 24, 2019

Conversation

@ozkriff
Copy link
Contributor

commented Feb 21, 2019

See #569

@ozkriff

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@icefoxen r? :)

@icefoxen

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2019

Yeah, I'm good. I just want to try to make unit tests for text metrics that actually work, to go with this, and want to leave this open so I don't forget. Hopefully I'll have time to do that tomorrow.

@icefoxen icefoxen merged commit e4af0ce into ggez:master Feb 24, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.