Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce namespaces? #13

Closed
gggeek opened this issue Dec 8, 2014 · 7 comments
Closed

introduce namespaces? #13

gggeek opened this issue Dec 8, 2014 · 7 comments

Comments

@gggeek
Copy link
Owner

gggeek commented Dec 8, 2014

pro: might make it easier to autoload stuff

con: will break 100% of the existing code out there. Unless we provide shims for everything, but that can be quite a chore, and it might force the base libs to be more complex than needed.

Any suggestion?

@gggeek gggeek changed the title introduce namespaces introduce namespaces? Dec 8, 2014
@HMAZonderland
Copy link
Contributor

If you wish to upgrade to a minimum of php53 you will have to introduce autoloading. Another con is you could build PEAR/Composer packages. This will ease the way you could integrate, maintain and update this tool in projects.

Sometimes you will have to make a sacrifice, in this case it would be 100% breaking of the code.

Otherwise release a complete new version => phpxmlrpc-NG

@gggeek
Copy link
Owner Author

gggeek commented Dec 10, 2014

You should start looking (contributing?) at the php53 brnch, as that's where most of these things are happening right now :-)

I personally do not think PEAR is worth implementing any more. Old farts can still do tarball installs, everybody else use composer.

As for composer, version 3.0 of the lib is already installable via Composer; you will most likely have problems with proper autoloading though.

Not sure why you mention pear/composer as a "con" though. Am I missing something?

As for phpxmlrpc-ng: I am still not convinced that a best-of-both-worlds approach is possible. Stay tuned (in other words: have a phpxmlrpc-ng API using namespaces, and keep around the old .inc files which provide full backwards compatibility. maybe those could be split off to a separate package in the end)

@HMAZonderland
Copy link
Contributor

Well you should make it more easy to integrate phpxmlrpc into projects. For example adding it as a composer package would add it into PhpStorm (my editor of choice) Composer package manager. 1 click and its installed.

To contradict your question; why isn't pear/composer/phar a con?

@gggeek
Copy link
Owner Author

gggeek commented Dec 10, 2014

pear/composer/phar => make life easier for developers => a pro

@HMAZonderland
Copy link
Contributor

Ahah. Hmm. My English is failing.

@gggeek
Copy link
Owner Author

gggeek commented Feb 21, 2015

Classes have been refactored and namespaced (in branch php53).
Left to do: move all code in the demo/ and debugger/ directories to use the new naming

@gggeek gggeek modified the milestone: 4.0 Apr 19, 2015
@gggeek
Copy link
Owner Author

gggeek commented Apr 19, 2015

All code in demo and debugger is legacy-clean; only tests left to use the compat layer, so that it is tested as well

@gggeek gggeek closed this as completed Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants