From 366abe71a63a0a1f025543e37b7dcdfdffb28956 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Tue, 21 Oct 2025 15:17:08 +0200 Subject: [PATCH 1/9] wip paddleocr --- convert_hf_to_gguf.py | 36 +++++++++++++++++++++++++++++++++++- gguf-py/gguf/constants.py | 3 +++ gguf-py/gguf/gguf_writer.py | 6 ++++++ 3 files changed, 44 insertions(+), 1 deletion(-) diff --git a/convert_hf_to_gguf.py b/convert_hf_to_gguf.py index ed99dc8477231..d7706dd24c272 100755 --- a/convert_hf_to_gguf.py +++ b/convert_hf_to_gguf.py @@ -3234,7 +3234,7 @@ def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iter yield from super().modify_tensors(data_torch, name, bid) -@ModelBase.register("Ernie4_5_ForCausalLM", "Ernie4_5ForCausalLM") +@ModelBase.register("Ernie4_5_ForCausalLM", "Ernie4_5ForCausalLM", "PaddleOCRVLForConditionalGeneration") class Ernie4_5Model(TextModel): model_arch = gguf.MODEL_ARCH.ERNIE4_5 @@ -3250,6 +3250,10 @@ def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iter if (head_dim := self.hparams.get("head_dim")) is None: head_dim = self.hparams["hidden_size"] // num_heads + if "mlp_AR" in name or "vision_model" in name: + # skip vision model and projector tensors + return [] + if "ernie." in name: name = name.replace("ernie.", "model.") # split the qkv weights @@ -3368,6 +3372,36 @@ def prepare_tensors(self): raise ValueError(f"Unprocessed experts: {experts}") +@ModelBase.register("SiglipVisionModel") +class PaddleOCRVisionModel(MmprojModel): + # PaddleOCR uses Siglip under the hood + min_pixels: int = 0 + max_pixels: int = 0 + + def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) + assert self.hparams_vision is not None + self.min_pixels = self.preprocessor_config["size"]["min_pixels"] + self.max_pixels = self.preprocessor_config["size"]["max_pixels"] + self.hparams_vision["image_size"] = int(math.sqrt(self.max_pixels)) + + def set_gguf_parameters(self): + super().set_gguf_parameters() + assert self.hparams_vision is not None + hparams = self.hparams_vision + self.gguf_writer.add_clip_projector_type(gguf.VisionProjectorType.PADDLEOCR) + self.gguf_writer.add_vision_max_pixels(self.max_pixels) + self.gguf_writer.add_vision_min_pixels(self.min_pixels) + self.gguf_writer.add_vision_use_gelu(True) + self.gguf_writer.add_vision_attention_layernorm_eps(hparams.get("rms_norm_eps", 1e-6)) + + def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: + del bid # unused + if "vision_model" in name or "mlp_AR" in name: + return [(self.map_tensor_name(name), data_torch)] + return [] # skip other tensors + + @ModelBase.register( "Qwen2VLModel", "Qwen2VLForConditionalGeneration", diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index 1b71fb3749aaa..ff947503afc17 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -265,6 +265,8 @@ class Clip: class ClipVision: IMAGE_SIZE = "clip.vision.image_size" + MAX_PIXELS = "clip.vision.max_pixels" + MIN_PIXELS = "clip.vision.min_pixels" PREPROC_IMAGE_SIZE = "clip.vision.preproc_image_size" PATCH_SIZE = "clip.vision.patch_size" EMBEDDING_LENGTH = "clip.vision.embedding_length" @@ -3062,6 +3064,7 @@ class VisionProjectorType: VOXTRAL = "voxtral" LFM2 = "lfm2" KIMIVL = "kimivl" + PADDLEOCR = "paddleocr" # Items here are (block size, type size) diff --git a/gguf-py/gguf/gguf_writer.py b/gguf-py/gguf/gguf_writer.py index d52d4f40f7884..602df3cb7b56f 100644 --- a/gguf-py/gguf/gguf_writer.py +++ b/gguf-py/gguf/gguf_writer.py @@ -1029,6 +1029,12 @@ def add_vision_projection_dim(self, value: int) -> None: def add_vision_patch_size(self, value: int) -> None: self.add_uint32(Keys.ClipVision.PATCH_SIZE, value) + def add_vision_max_pixels(self, value: int) -> None: + self.add_uint32(Keys.ClipVision.MAX_PIXELS, value) + + def add_vision_min_pixels(self, value: int) -> None: + self.add_uint32(Keys.ClipVision.MIN_PIXELS, value) + def add_vision_embedding_length(self, value: int) -> None: self.add_uint32(Keys.ClipVision.EMBEDDING_LENGTH, value) From e7a485c86cfe1f697ae42ec95412fc02ef170a55 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Wed, 22 Oct 2025 11:54:48 +0200 Subject: [PATCH 2/9] convert vision encoder ok --- convert_hf_to_gguf.py | 18 ++++++++++++++++-- gguf-py/gguf/constants.py | 9 +++++++++ gguf-py/gguf/tensor_mapping.py | 19 +++++++++++++++++++ 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/convert_hf_to_gguf.py b/convert_hf_to_gguf.py index d7706dd24c272..4f8a2f8121e6e 100755 --- a/convert_hf_to_gguf.py +++ b/convert_hf_to_gguf.py @@ -3374,7 +3374,7 @@ def prepare_tensors(self): @ModelBase.register("SiglipVisionModel") class PaddleOCRVisionModel(MmprojModel): - # PaddleOCR uses Siglip under the hood + # PaddleOCR-VL uses a modified version of Siglip min_pixels: int = 0 max_pixels: int = 0 @@ -3397,8 +3397,22 @@ def set_gguf_parameters(self): def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: del bid # unused + name = name.replace("visual.", "model.") + if "vision_model" in name or "mlp_AR" in name: - return [(self.map_tensor_name(name), data_torch)] + if "packing_position_embedding" in name: + return [] # unused + elif "head.attention.in_proj_" in name: + chunks = data_torch.chunk(3, dim=0) + name = name.replace("_bias", ".bias") + name = name.replace("_weight", ".weight") + return [ + (self.map_tensor_name(name.replace("in_proj", "in_proj_q")), chunks[0]), + (self.map_tensor_name(name.replace("in_proj", "in_proj_k")), chunks[1]), + (self.map_tensor_name(name.replace("in_proj", "in_proj_v")), chunks[2]), + ] + else: + return [(self.map_tensor_name(name), data_torch)] return [] # skip other tensors diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index ff947503afc17..b6cebb4cacb8c 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -640,6 +640,9 @@ class MODEL_TENSOR(IntEnum): V_RESMPL_Q_NORM = auto() # minicpmv V_RESMPL_PROJ = auto() # minicpmv V_RESMPL_QUERY = auto() # minicpmv + V_RESMPL_ATTN_NORM = auto() # PaddleOCR-VL + V_RESMPL_FFN_UP = auto() # PaddleOCR-VL + V_RESMPL_FFN_DOWN = auto() # PaddleOCR-VL V_TOK_EMBD_IMG_BREAK = auto() # pixtral V_MM_PATCH_MERGER = auto() # mistral small 3.1 # audio (mtmd) @@ -986,6 +989,9 @@ class MODEL_TENSOR(IntEnum): MODEL_TENSOR.V_RESMPL_Q_NORM: "resampler.ln_q", MODEL_TENSOR.V_RESMPL_PROJ: "resampler.proj", MODEL_TENSOR.V_RESMPL_QUERY: "resampler.query", + MODEL_TENSOR.V_RESMPL_ATTN_NORM: "resampler.ln2", + MODEL_TENSOR.V_RESMPL_FFN_UP: "resampler.ffn_up", + MODEL_TENSOR.V_RESMPL_FFN_DOWN: "resampler.ffn_down", MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK: "v.token_embd.img_break", # pixtral MODEL_TENSOR.V_MM_PATCH_MERGER: "mm.patch_merger", # mistral small 3.1 # audio (mtmd) @@ -1054,6 +1060,9 @@ class MODEL_TENSOR(IntEnum): MODEL_TENSOR.V_RESMPL_Q_NORM, MODEL_TENSOR.V_RESMPL_PROJ, MODEL_TENSOR.V_RESMPL_QUERY, + MODEL_TENSOR.V_RESMPL_ATTN_NORM, + MODEL_TENSOR.V_RESMPL_FFN_UP, + MODEL_TENSOR.V_RESMPL_FFN_DOWN, MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK, MODEL_TENSOR.V_MM_PATCH_MERGER, # audio diff --git a/gguf-py/gguf/tensor_mapping.py b/gguf-py/gguf/tensor_mapping.py index d7dcd8efb8426..f7c31b69cb1b8 100644 --- a/gguf-py/gguf/tensor_mapping.py +++ b/gguf-py/gguf/tensor_mapping.py @@ -1144,6 +1144,7 @@ class TensorNameMap: MODEL_TENSOR.V_MMPROJ: ( "multi_modal_projector.linear_{bid}", "visual.merger.mlp.{bid}", # qwen2vl + "mlp_AR.linear_{bid}", # PaddleOCR-VL ), MODEL_TENSOR.V_MMPROJ_FC: ( @@ -1338,6 +1339,7 @@ class TensorNameMap: "multi_modal_projector.layer_norm", "multi_modal_projector.pre_norm", "pre_mm_projector_norm", + "mlp_AR.pre_norm", # PaddleOCR-VL ), MODEL_TENSOR.V_MM_SOFT_EMB_NORM: ( @@ -1350,18 +1352,26 @@ class TensorNameMap: MODEL_TENSOR.V_RESMPL_ATTN_Q: ( "resampler.attn.in_proj_q", # tensor generated from resampler.attn.in_proj + "model.vision_model.head.attention.in_proj_q", # PaddleOCR-VL (generated tensor) ), MODEL_TENSOR.V_RESMPL_ATTN_K: ( "resampler.attn.in_proj_k", # tensor generated from resampler.attn.in_proj + "model.vision_model.head.attention.in_proj_k", # PaddleOCR-VL (generated tensor) ), MODEL_TENSOR.V_RESMPL_ATTN_V: ( "resampler.attn.in_proj_v", # tensor generated from resampler.attn.in_proj + "model.vision_model.head.attention.in_proj_v", # PaddleOCR-VL (generated tensor) ), MODEL_TENSOR.V_RESMPL_ATTN_OUT: ( "resampler.attn.out_proj", + "model.vision_model.head.attention.out_proj", + ), + + MODEL_TENSOR.V_RESMPL_ATTN_NORM: ( + "model.vision_model.head.layernorm", # PaddleOCR-VL ), MODEL_TENSOR.V_RESMPL_KV: ( @@ -1386,6 +1396,15 @@ class TensorNameMap: MODEL_TENSOR.V_RESMPL_QUERY: ( "resampler.query", + "model.vision_model.head.probe", # PaddleOCR-VL + ), + + MODEL_TENSOR.V_RESMPL_FFN_UP: ( + "model.vision_model.head.mlp.fc1", # PaddleOCR-VL + ), + + MODEL_TENSOR.V_RESMPL_FFN_DOWN: ( + "model.vision_model.head.mlp.fc2", # PaddleOCR-VL ), MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK: ( From ac41b54adf7e91676144990c12ad0aac17840eca Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Wed, 22 Oct 2025 13:59:08 +0200 Subject: [PATCH 3/9] fix chat template --- common/arg.cpp | 2 +- common/chat.cpp | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/common/arg.cpp b/common/arg.cpp index 33ed7ae857269..a25743c899862 100644 --- a/common/arg.cpp +++ b/common/arg.cpp @@ -3435,7 +3435,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex [](common_params & params) { params.use_jinja = true; } - ).set_examples({LLAMA_EXAMPLE_SERVER, LLAMA_EXAMPLE_MAIN}).set_env("LLAMA_ARG_JINJA")); + ).set_examples({LLAMA_EXAMPLE_SERVER, LLAMA_EXAMPLE_MAIN, LLAMA_EXAMPLE_MTMD}).set_env("LLAMA_ARG_JINJA")); add_opt(common_arg( {"--reasoning-format"}, "FORMAT", "controls whether thought tags are allowed and/or extracted from the response, and in which format they're returned; one of:\n" diff --git a/common/chat.cpp b/common/chat.cpp index 8587140e1ff0a..9dcb820d08072 100644 --- a/common/chat.cpp +++ b/common/chat.cpp @@ -579,6 +579,11 @@ common_chat_templates_ptr common_chat_templates_init( "{%- if false %}"); } + // TODO @ngxson : hot fix for PaddleOCR + if (default_template_src.find("<|IMAGE_PLACEHOLDER|>") != std::string::npos) { + string_replace_all(default_template_src, "<|IMAGE_START|><|IMAGE_PLACEHOLDER|><|IMAGE_END|>", ""); + } + std::string token_bos = bos_token_override; std::string token_eos = eos_token_override; bool add_bos = false; From be802893cc3e471fac6da8c7df1780f590366443 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Wed, 22 Oct 2025 13:59:25 +0200 Subject: [PATCH 4/9] rm V_RESMPL_ATTN_NORM --- gguf-py/gguf/constants.py | 3 --- gguf-py/gguf/tensor_mapping.py | 5 +---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index b6cebb4cacb8c..da12ed356a392 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -640,7 +640,6 @@ class MODEL_TENSOR(IntEnum): V_RESMPL_Q_NORM = auto() # minicpmv V_RESMPL_PROJ = auto() # minicpmv V_RESMPL_QUERY = auto() # minicpmv - V_RESMPL_ATTN_NORM = auto() # PaddleOCR-VL V_RESMPL_FFN_UP = auto() # PaddleOCR-VL V_RESMPL_FFN_DOWN = auto() # PaddleOCR-VL V_TOK_EMBD_IMG_BREAK = auto() # pixtral @@ -989,7 +988,6 @@ class MODEL_TENSOR(IntEnum): MODEL_TENSOR.V_RESMPL_Q_NORM: "resampler.ln_q", MODEL_TENSOR.V_RESMPL_PROJ: "resampler.proj", MODEL_TENSOR.V_RESMPL_QUERY: "resampler.query", - MODEL_TENSOR.V_RESMPL_ATTN_NORM: "resampler.ln2", MODEL_TENSOR.V_RESMPL_FFN_UP: "resampler.ffn_up", MODEL_TENSOR.V_RESMPL_FFN_DOWN: "resampler.ffn_down", MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK: "v.token_embd.img_break", # pixtral @@ -1060,7 +1058,6 @@ class MODEL_TENSOR(IntEnum): MODEL_TENSOR.V_RESMPL_Q_NORM, MODEL_TENSOR.V_RESMPL_PROJ, MODEL_TENSOR.V_RESMPL_QUERY, - MODEL_TENSOR.V_RESMPL_ATTN_NORM, MODEL_TENSOR.V_RESMPL_FFN_UP, MODEL_TENSOR.V_RESMPL_FFN_DOWN, MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK, diff --git a/gguf-py/gguf/tensor_mapping.py b/gguf-py/gguf/tensor_mapping.py index f7c31b69cb1b8..86fede1d54130 100644 --- a/gguf-py/gguf/tensor_mapping.py +++ b/gguf-py/gguf/tensor_mapping.py @@ -1370,16 +1370,13 @@ class TensorNameMap: "model.vision_model.head.attention.out_proj", ), - MODEL_TENSOR.V_RESMPL_ATTN_NORM: ( - "model.vision_model.head.layernorm", # PaddleOCR-VL - ), - MODEL_TENSOR.V_RESMPL_KV: ( "resampler.kv_proj", ), MODEL_TENSOR.V_RESMPL_POST_NORM: ( "resampler.ln_post", + "model.vision_model.head.layernorm", # PaddleOCR-VL ), MODEL_TENSOR.V_RESMPL_KV_NORM: ( From ddfaca720bc66dbc848de0c55a1e514be8c53f37 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Wed, 22 Oct 2025 13:59:32 +0200 Subject: [PATCH 5/9] model load ok --- tools/mtmd/clip-impl.h | 16 +++-- tools/mtmd/clip.cpp | 150 +++++++++++++++++++++++++++++++++++------ tools/mtmd/mtmd.cpp | 4 ++ 3 files changed, 145 insertions(+), 25 deletions(-) diff --git a/tools/mtmd/clip-impl.h b/tools/mtmd/clip-impl.h index 1669fad99b36b..534b806f88be4 100644 --- a/tools/mtmd/clip-impl.h +++ b/tools/mtmd/clip-impl.h @@ -95,12 +95,14 @@ #define TN_TOK_GLM_EOI "adapter.eoi" // glm-edge (these embeddings are not in text model) // mimicpmv -#define TN_MINICPMV_POS_EMBD_K "resampler.pos_embed_k" -#define TN_MINICPMV_QUERY "resampler.query" -#define TN_MINICPMV_PROJ "resampler.proj.weight" -#define TN_MINICPMV_KV_PROJ "resampler.kv.weight" -#define TN_MINICPMV_ATTN "resampler.attn.%s.%s" -#define TN_MINICPMV_LN "resampler.ln_%s.%s" +#define TN_RESAMPL_POS_EMBD_K "resampler.pos_embed_k" +#define TN_RESAMPL_QUERY "resampler.query" +#define TN_RESAMPL_PROJ "resampler.proj.weight" +#define TN_RESAMPL_KV_PROJ "resampler.kv.weight" +#define TN_RESAMPL_ATTN "resampler.attn.%s.%s" +#define TN_RESAMPL_LN "resampler.ln_%s.%s" +#define TN_RESAMPL_FFN_UP "resampler.ffn_up.%s" +#define TN_RESAMPL_FFN_DOWN "resampler.ffn_down.%s" #define TN_GLM_ADAPER_CONV "adapter.conv.%s" #define TN_GLM_ADAPTER_LINEAR "adapter.linear.linear.%s" @@ -139,6 +141,7 @@ enum projector_type { PROJECTOR_TYPE_VOXTRAL, PROJECTOR_TYPE_LFM2, PROJECTOR_TYPE_KIMIVL, + PROJECTOR_TYPE_PADDLEOCR, PROJECTOR_TYPE_UNKNOWN, }; @@ -161,6 +164,7 @@ static std::map PROJECTOR_TYPE_NAMES = { { PROJECTOR_TYPE_VOXTRAL, "voxtral"}, { PROJECTOR_TYPE_LFM2, "lfm2"}, { PROJECTOR_TYPE_KIMIVL, "kimivl"}, + { PROJECTOR_TYPE_PADDLEOCR, "paddleocr"}, }; static projector_type clip_projector_type_from_string(const std::string & str) { diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index f2abf88523843..9b926b219c1e4 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -342,6 +342,10 @@ struct clip_model { ggml_tensor * mm_model_ln_kv_b = nullptr; ggml_tensor * mm_model_ln_post_w = nullptr; ggml_tensor * mm_model_ln_post_b = nullptr; + ggml_tensor * mm_model_ffn_up_w = nullptr; + ggml_tensor * mm_model_ffn_up_b = nullptr; + ggml_tensor * mm_model_ffn_down_w = nullptr; + ggml_tensor * mm_model_ffn_down_b = nullptr; // gemma3 ggml_tensor * mm_input_proj_w = nullptr; @@ -1136,6 +1140,77 @@ struct clip_graph { return gf; } + ggml_cgraph * build_paddleocr() { + // 2D input positions + ggml_tensor * pos_h = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_patches); + ggml_set_name(pos_h, "pos_h"); + ggml_set_input(pos_h); + + ggml_tensor * pos_w = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_patches); + ggml_set_name(pos_w, "pos_w"); + ggml_set_input(pos_w); + + ggml_tensor * learned_pos_embd = resize_position_embeddings(); + + // build ViT with 2D position embeddings + auto add_pos = [&](ggml_tensor * cur, const clip_layer &) { + // first half is X axis and second half is Y axis + return build_rope_2d(ctx0, cur, pos_w, pos_h, hparams.rope_theta, false); + }; + + ggml_tensor * inp = build_inp(); + ggml_tensor * cur = build_vit( + inp, n_patches, + NORM_TYPE_NORMAL, + hparams.ffn_op, + learned_pos_embd, + add_pos); + + cb(cur, "vit_out", -1); + + { + // SiglipMultiheadAttentionPoolingHead + int64_t n_pos = cur->ne[1]; + ggml_tensor * Qcur = model.mm_model_query; + ggml_tensor * Kcur = cur; + ggml_tensor * Vcur = cur; + + Qcur = ggml_reshape_3d(ctx0, Qcur, d_head, n_head, n_pos); + Kcur = ggml_reshape_3d(ctx0, Kcur, d_head, n_head, n_pos); + Vcur = ggml_reshape_3d(ctx0, Vcur, d_head, n_head, n_pos); + + cb(Qcur, "resampl_Qcur", -1); + cb(Kcur, "resampl_Kcur", -1); + cb(Vcur, "resampl_Vcur", -1); + + float kq_scale = 1.0f / sqrtf((float)(d_head)); + cur = build_attn(model.mm_model_attn_o_w, model.mm_model_attn_o_b, + Qcur, Kcur, Vcur, nullptr, kq_scale, -1); + + cb(cur, "resampl_attn_out", -1); + + cur = build_norm(cur, model.mm_model_ln_post_w, model.mm_model_ln_post_b, + NORM_TYPE_NORMAL, eps, -1); + + cb(cur, "resampl_out", -1); + } + + { + // SiglipMLP + cur = build_ffn(cur, + model.mm_model_ffn_up_w, model.mm_model_ffn_up_b, + nullptr, nullptr, + model.mm_model_ffn_down_w, model.mm_model_ffn_down_b, + hparams.ffn_op, -1); + cb(cur, "mlp_out", -1); + } + + // build the graph + ggml_build_forward_expand(gf, cur); + + return gf; + } + // this graph is used by llava, granite and glm // due to having embedding_stack (used by granite), we cannot reuse build_vit ggml_cgraph * build_llava() { @@ -2125,6 +2200,10 @@ static ggml_cgraph * clip_image_build_graph(clip_ctx * ctx, const clip_image_f32 { res = graph.build_kimivl(); } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + res = graph.build_paddleocr(); + } break; default: { res = graph.build_llava(); @@ -2440,6 +2519,10 @@ struct clip_model_loader { hparams.ffn_op = FFN_GELU_ERF; log_ffn_op = "gelu_erf"; // temporary solution for logging } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + hparams.proj_scale_factor = 1; + } break; default: break; } @@ -2650,25 +2733,25 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_MINICPMV: { - // model.mm_model_pos_embed = get_tensor(new_clip->ctx_data, TN_MINICPMV_POS_EMBD); - model.mm_model_pos_embed_k = get_tensor(TN_MINICPMV_POS_EMBD_K); - model.mm_model_query = get_tensor(TN_MINICPMV_QUERY); - model.mm_model_proj = get_tensor(TN_MINICPMV_PROJ); - model.mm_model_kv_proj = get_tensor(TN_MINICPMV_KV_PROJ); - model.mm_model_attn_q_w = get_tensor(string_format(TN_MINICPMV_ATTN, "q", "weight")); - model.mm_model_attn_k_w = get_tensor(string_format(TN_MINICPMV_ATTN, "k", "weight")); - model.mm_model_attn_v_w = get_tensor(string_format(TN_MINICPMV_ATTN, "v", "weight")); - model.mm_model_attn_q_b = get_tensor(string_format(TN_MINICPMV_ATTN, "q", "bias")); - model.mm_model_attn_k_b = get_tensor(string_format(TN_MINICPMV_ATTN, "k", "bias")); - model.mm_model_attn_v_b = get_tensor(string_format(TN_MINICPMV_ATTN, "v", "bias")); - model.mm_model_attn_o_w = get_tensor(string_format(TN_MINICPMV_ATTN, "out", "weight")); - model.mm_model_attn_o_b = get_tensor(string_format(TN_MINICPMV_ATTN, "out", "bias")); - model.mm_model_ln_q_w = get_tensor(string_format(TN_MINICPMV_LN, "q", "weight")); - model.mm_model_ln_q_b = get_tensor(string_format(TN_MINICPMV_LN, "q", "bias")); - model.mm_model_ln_kv_w = get_tensor(string_format(TN_MINICPMV_LN, "kv", "weight")); - model.mm_model_ln_kv_b = get_tensor(string_format(TN_MINICPMV_LN, "kv", "bias")); - model.mm_model_ln_post_w = get_tensor(string_format(TN_MINICPMV_LN, "post", "weight")); - model.mm_model_ln_post_b = get_tensor(string_format(TN_MINICPMV_LN, "post", "bias")); + // model.mm_model_pos_embed = get_tensor(new_clip->ctx_data, TN_RESAMPL_POS_EMBD); + model.mm_model_pos_embed_k = get_tensor(TN_RESAMPL_POS_EMBD_K); + model.mm_model_query = get_tensor(TN_RESAMPL_QUERY); + model.mm_model_proj = get_tensor(TN_RESAMPL_PROJ); + model.mm_model_kv_proj = get_tensor(TN_RESAMPL_KV_PROJ); + model.mm_model_attn_q_w = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "weight")); + model.mm_model_attn_k_w = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "weight")); + model.mm_model_attn_v_w = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "weight")); + model.mm_model_attn_q_b = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "bias")); + model.mm_model_attn_k_b = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "bias")); + model.mm_model_attn_v_b = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "bias")); + model.mm_model_attn_o_w = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "weight")); + model.mm_model_attn_o_b = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "bias")); + model.mm_model_ln_q_w = get_tensor(string_format(TN_RESAMPL_LN, "q", "weight")); + model.mm_model_ln_q_b = get_tensor(string_format(TN_RESAMPL_LN, "q", "bias")); + model.mm_model_ln_kv_w = get_tensor(string_format(TN_RESAMPL_LN, "kv", "weight")); + model.mm_model_ln_kv_b = get_tensor(string_format(TN_RESAMPL_LN, "kv", "bias")); + model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); + model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); } break; case PROJECTOR_TYPE_GLM_EDGE: { @@ -2766,6 +2849,32 @@ struct clip_model_loader { model.mm_model_mlp_1_w = get_tensor(string_format(TN_MVLM_PROJ_MLP, 1, "weight")); model.mm_model_mlp_2_w = get_tensor(string_format(TN_MVLM_PROJ_MLP, 2, "weight")); } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + model.mm_model_query = get_tensor(TN_RESAMPL_QUERY); + model.mm_model_attn_q_w = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "weight")); + model.mm_model_attn_k_w = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "weight")); + model.mm_model_attn_v_w = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "weight")); + model.mm_model_attn_q_b = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "bias")); + model.mm_model_attn_k_b = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "bias")); + model.mm_model_attn_v_b = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "bias")); + model.mm_model_attn_o_w = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "weight")); + model.mm_model_attn_o_b = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "bias")); + model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); + model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); + // resampler ffn + model.mm_model_ffn_up_w = get_tensor(string_format(TN_RESAMPL_FFN_UP, "weight")); + model.mm_model_ffn_up_b = get_tensor(string_format(TN_RESAMPL_FFN_UP, "bias")); + model.mm_model_ffn_down_w = get_tensor(string_format(TN_RESAMPL_FFN_DOWN, "weight")); + model.mm_model_ffn_down_b = get_tensor(string_format(TN_RESAMPL_FFN_DOWN, "bias")); + // projector ffn + model.mm_1_w = get_tensor(string_format(TN_LLAVA_PROJ, 1, "weight")); + model.mm_1_b = get_tensor(string_format(TN_LLAVA_PROJ, 1, "bias")); + model.mm_2_w = get_tensor(string_format(TN_LLAVA_PROJ, 2, "weight")); + model.mm_2_b = get_tensor(string_format(TN_LLAVA_PROJ, 2, "bias")); + model.mm_input_norm_w = get_tensor(TN_MM_INP_NORM); + model.mm_input_norm_b = get_tensor(TN_MM_INP_NORM_B); + } break; default: GGML_ASSERT(false && "unknown projector type"); } @@ -3856,6 +3965,7 @@ int clip_n_output_tokens(const struct clip_ctx * ctx, struct clip_image_f32 * im } break; case PROJECTOR_TYPE_LFM2: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: { // dynamic size int scale_factor = ctx->model.hparams.proj_scale_factor; @@ -4247,6 +4357,7 @@ bool clip_image_batch_encode(clip_ctx * ctx, const int n_threads, const clip_ima } break; case PROJECTOR_TYPE_PIXTRAL: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: { // set the 2D positions int n_patches_per_col = image_size_width / patch_size; @@ -4402,6 +4513,7 @@ int clip_n_mmproj_embd(const struct clip_ctx * ctx) { return ctx->model.mm_fc_w->ne[1]; case PROJECTOR_TYPE_LFM2: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: return ctx->model.mm_2_w->ne[1]; default: GGML_ABORT("Unknown projector type"); diff --git a/tools/mtmd/mtmd.cpp b/tools/mtmd/mtmd.cpp index 4d487581ae0a0..0c461ad12070d 100644 --- a/tools/mtmd/mtmd.cpp +++ b/tools/mtmd/mtmd.cpp @@ -275,6 +275,10 @@ struct mtmd_context { img_beg = ""; img_end = ""; + } else if (proj == PROJECTOR_TYPE_PADDLEOCR) { + // <|IMAGE_START|> ... (image embeddings) ... <|IMAGE_END|> + img_beg = "<|IMAGE_START|>"; + img_end = "<|IMAGE_END|>"; } } From ea2fbb803238b28c7c1327099bdf20885367923e Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Wed, 22 Oct 2025 14:08:48 +0200 Subject: [PATCH 6/9] output text but gibberish --- tools/mtmd/clip.cpp | 6 ++++-- tools/mtmd/mtmd-cli.cpp | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 9b926b219c1e4..48572a8cbe1c0 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -1171,7 +1171,7 @@ struct clip_graph { { // SiglipMultiheadAttentionPoolingHead int64_t n_pos = cur->ne[1]; - ggml_tensor * Qcur = model.mm_model_query; + ggml_tensor * Qcur = ggml_repeat(ctx0, model.mm_model_query, cur); ggml_tensor * Kcur = cur; ggml_tensor * Vcur = cur; @@ -3731,7 +3731,9 @@ bool clip_image_preprocess(struct clip_ctx * ctx, const clip_image_u8 * img, str res_imgs->entries.push_back(std::move(img_f32)); return true; - } else if (ctx->proj_type() == PROJECTOR_TYPE_PIXTRAL) { + } else if (ctx->proj_type() == PROJECTOR_TYPE_PIXTRAL + || ctx->proj_type() == PROJECTOR_TYPE_PADDLEOCR + ) { clip_image_u8 resized_image; auto new_size = image_manipulation::calc_size_preserved_ratio(original_size, params.patch_size, params.image_size); image_manipulation::bilinear_resize(*img, resized_image, new_size.width, new_size.height); diff --git a/tools/mtmd/mtmd-cli.cpp b/tools/mtmd/mtmd-cli.cpp index 5fde6ca0c32ae..d72e28153b5ba 100644 --- a/tools/mtmd/mtmd-cli.cpp +++ b/tools/mtmd/mtmd-cli.cpp @@ -85,6 +85,7 @@ struct mtmd_cli_context { int n_threads = 1; llama_pos n_past = 0; + bool use_jinja = false; mtmd_cli_context(common_params & params) : llama_init(common_init_from_params(params)) { model = llama_init.model.get(); @@ -108,6 +109,7 @@ struct mtmd_cli_context { } tmpls = common_chat_templates_init(model, params.chat_template); + use_jinja = params.use_jinja; LOG_INF("%s: chat template example:\n%s\n", __func__, common_chat_format_example(tmpls.get(), params.use_jinja, params.default_template_kwargs).c_str()); init_vision_context(params); @@ -200,7 +202,7 @@ static int eval_message(mtmd_cli_context & ctx, common_chat_msg & msg, bool add_ common_chat_templates_inputs tmpl_inputs; tmpl_inputs.messages = {msg}; tmpl_inputs.add_generation_prompt = true; - tmpl_inputs.use_jinja = false; // jinja is buggy here + tmpl_inputs.use_jinja = ctx.use_jinja; auto formatted_chat = common_chat_templates_apply(ctx.tmpls.get(), tmpl_inputs); LOG_DBG("formatted_chat.prompt: %s\n", formatted_chat.prompt.c_str()); From a342f52cde7d19505bc022df719f05f5c07d293a Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Sun, 26 Oct 2025 00:30:05 +0200 Subject: [PATCH 7/9] correct projector --- convert_hf_to_gguf.py | 12 ++---- gguf-py/gguf/constants.py | 4 -- gguf-py/gguf/tensor_mapping.py | 13 ------ tools/mtmd/clip.cpp | 72 +++++++++++++++------------------- tools/mtmd/mtmd-cli.cpp | 1 - 5 files changed, 35 insertions(+), 67 deletions(-) diff --git a/convert_hf_to_gguf.py b/convert_hf_to_gguf.py index 4f8a2f8121e6e..2d8c4c6099dbe 100755 --- a/convert_hf_to_gguf.py +++ b/convert_hf_to_gguf.py @@ -3402,15 +3402,9 @@ def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iter if "vision_model" in name or "mlp_AR" in name: if "packing_position_embedding" in name: return [] # unused - elif "head.attention.in_proj_" in name: - chunks = data_torch.chunk(3, dim=0) - name = name.replace("_bias", ".bias") - name = name.replace("_weight", ".weight") - return [ - (self.map_tensor_name(name.replace("in_proj", "in_proj_q")), chunks[0]), - (self.map_tensor_name(name.replace("in_proj", "in_proj_k")), chunks[1]), - (self.map_tensor_name(name.replace("in_proj", "in_proj_v")), chunks[2]), - ] + elif "vision_model.head" in name: + # we don't yet support image embeddings for this model + return [] else: return [(self.map_tensor_name(name), data_torch)] return [] # skip other tensors diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index da12ed356a392..5259cdb3212a9 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -640,8 +640,6 @@ class MODEL_TENSOR(IntEnum): V_RESMPL_Q_NORM = auto() # minicpmv V_RESMPL_PROJ = auto() # minicpmv V_RESMPL_QUERY = auto() # minicpmv - V_RESMPL_FFN_UP = auto() # PaddleOCR-VL - V_RESMPL_FFN_DOWN = auto() # PaddleOCR-VL V_TOK_EMBD_IMG_BREAK = auto() # pixtral V_MM_PATCH_MERGER = auto() # mistral small 3.1 # audio (mtmd) @@ -988,8 +986,6 @@ class MODEL_TENSOR(IntEnum): MODEL_TENSOR.V_RESMPL_Q_NORM: "resampler.ln_q", MODEL_TENSOR.V_RESMPL_PROJ: "resampler.proj", MODEL_TENSOR.V_RESMPL_QUERY: "resampler.query", - MODEL_TENSOR.V_RESMPL_FFN_UP: "resampler.ffn_up", - MODEL_TENSOR.V_RESMPL_FFN_DOWN: "resampler.ffn_down", MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK: "v.token_embd.img_break", # pixtral MODEL_TENSOR.V_MM_PATCH_MERGER: "mm.patch_merger", # mistral small 3.1 # audio (mtmd) diff --git a/gguf-py/gguf/tensor_mapping.py b/gguf-py/gguf/tensor_mapping.py index 86fede1d54130..b0591ddb276fc 100644 --- a/gguf-py/gguf/tensor_mapping.py +++ b/gguf-py/gguf/tensor_mapping.py @@ -1352,17 +1352,14 @@ class TensorNameMap: MODEL_TENSOR.V_RESMPL_ATTN_Q: ( "resampler.attn.in_proj_q", # tensor generated from resampler.attn.in_proj - "model.vision_model.head.attention.in_proj_q", # PaddleOCR-VL (generated tensor) ), MODEL_TENSOR.V_RESMPL_ATTN_K: ( "resampler.attn.in_proj_k", # tensor generated from resampler.attn.in_proj - "model.vision_model.head.attention.in_proj_k", # PaddleOCR-VL (generated tensor) ), MODEL_TENSOR.V_RESMPL_ATTN_V: ( "resampler.attn.in_proj_v", # tensor generated from resampler.attn.in_proj - "model.vision_model.head.attention.in_proj_v", # PaddleOCR-VL (generated tensor) ), MODEL_TENSOR.V_RESMPL_ATTN_OUT: ( @@ -1376,7 +1373,6 @@ class TensorNameMap: MODEL_TENSOR.V_RESMPL_POST_NORM: ( "resampler.ln_post", - "model.vision_model.head.layernorm", # PaddleOCR-VL ), MODEL_TENSOR.V_RESMPL_KV_NORM: ( @@ -1393,15 +1389,6 @@ class TensorNameMap: MODEL_TENSOR.V_RESMPL_QUERY: ( "resampler.query", - "model.vision_model.head.probe", # PaddleOCR-VL - ), - - MODEL_TENSOR.V_RESMPL_FFN_UP: ( - "model.vision_model.head.mlp.fc1", # PaddleOCR-VL - ), - - MODEL_TENSOR.V_RESMPL_FFN_DOWN: ( - "model.vision_model.head.mlp.fc2", # PaddleOCR-VL ), MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK: ( diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 48572a8cbe1c0..091c8f81604f3 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -342,10 +342,6 @@ struct clip_model { ggml_tensor * mm_model_ln_kv_b = nullptr; ggml_tensor * mm_model_ln_post_w = nullptr; ggml_tensor * mm_model_ln_post_b = nullptr; - ggml_tensor * mm_model_ffn_up_w = nullptr; - ggml_tensor * mm_model_ffn_up_b = nullptr; - ggml_tensor * mm_model_ffn_down_w = nullptr; - ggml_tensor * mm_model_ffn_down_b = nullptr; // gemma3 ggml_tensor * mm_input_proj_w = nullptr; @@ -1169,38 +1165,33 @@ struct clip_graph { cb(cur, "vit_out", -1); { - // SiglipMultiheadAttentionPoolingHead - int64_t n_pos = cur->ne[1]; - ggml_tensor * Qcur = ggml_repeat(ctx0, model.mm_model_query, cur); - ggml_tensor * Kcur = cur; - ggml_tensor * Vcur = cur; - - Qcur = ggml_reshape_3d(ctx0, Qcur, d_head, n_head, n_pos); - Kcur = ggml_reshape_3d(ctx0, Kcur, d_head, n_head, n_pos); - Vcur = ggml_reshape_3d(ctx0, Vcur, d_head, n_head, n_pos); - - cb(Qcur, "resampl_Qcur", -1); - cb(Kcur, "resampl_Kcur", -1); - cb(Vcur, "resampl_Vcur", -1); - - float kq_scale = 1.0f / sqrtf((float)(d_head)); - cur = build_attn(model.mm_model_attn_o_w, model.mm_model_attn_o_b, - Qcur, Kcur, Vcur, nullptr, kq_scale, -1); - - cb(cur, "resampl_attn_out", -1); - - cur = build_norm(cur, model.mm_model_ln_post_w, model.mm_model_ln_post_b, - NORM_TYPE_NORMAL, eps, -1); - - cb(cur, "resampl_out", -1); - } + // mlp_AR + float proj_norm_eps = 1e-5; // PaddleOCR uses hard-coded value eps=1e-5 for Projector + cur = build_norm(cur, + model.mm_input_norm_w, model.mm_input_norm_b, + NORM_TYPE_NORMAL, proj_norm_eps, -1); + //cur = build_patch_merge_permute(cur, hparams.proj_scale_factor); + + // stack and padding + int64_t stride = hparams.proj_scale_factor * hparams.proj_scale_factor; + int64_t n_embd = cur->ne[0]; + int64_t n_tokens = cur->ne[1]; + int64_t n_tokens_padded = CLIP_ALIGN(n_tokens, stride); + int64_t n_pad = n_tokens_padded - n_tokens; + if (n_pad > 0) { + cur = ggml_view_1d(ctx0, cur, ggml_nelements(cur), 0); + cur = ggml_pad(ctx0, cur, n_pad * n_embd, 0, 0, 0); + } + cur = ggml_view_2d(ctx0, cur, + n_embd * stride, + n_tokens_padded / stride, + ggml_row_size(cur->type, n_embd * stride), 0); + cb(cur, "after_stacked", -1); - { - // SiglipMLP cur = build_ffn(cur, - model.mm_model_ffn_up_w, model.mm_model_ffn_up_b, + model.mm_1_w, model.mm_1_b, nullptr, nullptr, - model.mm_model_ffn_down_w, model.mm_model_ffn_down_b, + model.mm_2_w, model.mm_2_b, hparams.ffn_op, -1); cb(cur, "mlp_out", -1); } @@ -2521,7 +2512,7 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_PADDLEOCR: { - hparams.proj_scale_factor = 1; + hparams.proj_scale_factor = 2; } break; default: break; @@ -2862,11 +2853,6 @@ struct clip_model_loader { model.mm_model_attn_o_b = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "bias")); model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); - // resampler ffn - model.mm_model_ffn_up_w = get_tensor(string_format(TN_RESAMPL_FFN_UP, "weight")); - model.mm_model_ffn_up_b = get_tensor(string_format(TN_RESAMPL_FFN_UP, "bias")); - model.mm_model_ffn_down_w = get_tensor(string_format(TN_RESAMPL_FFN_DOWN, "weight")); - model.mm_model_ffn_down_b = get_tensor(string_format(TN_RESAMPL_FFN_DOWN, "bias")); // projector ffn model.mm_1_w = get_tensor(string_format(TN_LLAVA_PROJ, 1, "weight")); model.mm_1_b = get_tensor(string_format(TN_LLAVA_PROJ, 1, "bias")); @@ -3967,7 +3953,6 @@ int clip_n_output_tokens(const struct clip_ctx * ctx, struct clip_image_f32 * im } break; case PROJECTOR_TYPE_LFM2: case PROJECTOR_TYPE_KIMIVL: - case PROJECTOR_TYPE_PADDLEOCR: { // dynamic size int scale_factor = ctx->model.hparams.proj_scale_factor; @@ -3976,6 +3961,13 @@ int clip_n_output_tokens(const struct clip_ctx * ctx, struct clip_image_f32 * im int y_patch = CLIP_ALIGN(img->ny, out_patch_size) / out_patch_size; n_patches = x_patch * y_patch; } break; + case PROJECTOR_TYPE_PADDLEOCR: + { + // dynamic size + int scale_factor = ctx->model.hparams.proj_scale_factor; + int stride = scale_factor * scale_factor; + n_patches = CLIP_ALIGN(n_patches, stride) / stride; + } break; case PROJECTOR_TYPE_PIXTRAL: { // dynamic size diff --git a/tools/mtmd/mtmd-cli.cpp b/tools/mtmd/mtmd-cli.cpp index f22fca9bee10c..fd1fb6581b163 100644 --- a/tools/mtmd/mtmd-cli.cpp +++ b/tools/mtmd/mtmd-cli.cpp @@ -87,7 +87,6 @@ struct mtmd_cli_context { int n_threads = 1; llama_pos n_past = 0; - bool use_jinja = false; mtmd_cli_context(common_params & params) : llama_init(common_init_from_params(params)) { model = llama_init.model.get(); From bd38d7fdd61a4b7d36d00d7f6d7c30e5a940e9c9 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Sun, 26 Oct 2025 00:32:44 +0200 Subject: [PATCH 8/9] fix conversion script --- gguf-py/gguf/constants.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/gguf-py/gguf/constants.py b/gguf-py/gguf/constants.py index 5259cdb3212a9..ff947503afc17 100644 --- a/gguf-py/gguf/constants.py +++ b/gguf-py/gguf/constants.py @@ -1054,8 +1054,6 @@ class MODEL_TENSOR(IntEnum): MODEL_TENSOR.V_RESMPL_Q_NORM, MODEL_TENSOR.V_RESMPL_PROJ, MODEL_TENSOR.V_RESMPL_QUERY, - MODEL_TENSOR.V_RESMPL_FFN_UP, - MODEL_TENSOR.V_RESMPL_FFN_DOWN, MODEL_TENSOR.V_TOK_EMBD_IMG_BREAK, MODEL_TENSOR.V_MM_PATCH_MERGER, # audio From 70e73128f2bfd34ea8f8f234a688c1b73b559d99 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Sun, 26 Oct 2025 00:35:19 +0200 Subject: [PATCH 9/9] fix model load --- tools/mtmd/clip.cpp | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp index 091c8f81604f3..ad62ff4340912 100644 --- a/tools/mtmd/clip.cpp +++ b/tools/mtmd/clip.cpp @@ -2776,6 +2776,7 @@ struct clip_model_loader { } break; case PROJECTOR_TYPE_LFM2: case PROJECTOR_TYPE_KIMIVL: + case PROJECTOR_TYPE_PADDLEOCR: { model.mm_input_norm_w = get_tensor(TN_MM_INP_NORM); model.mm_input_norm_b = get_tensor(TN_MM_INP_NORM_B); @@ -2840,27 +2841,6 @@ struct clip_model_loader { model.mm_model_mlp_1_w = get_tensor(string_format(TN_MVLM_PROJ_MLP, 1, "weight")); model.mm_model_mlp_2_w = get_tensor(string_format(TN_MVLM_PROJ_MLP, 2, "weight")); } break; - case PROJECTOR_TYPE_PADDLEOCR: - { - model.mm_model_query = get_tensor(TN_RESAMPL_QUERY); - model.mm_model_attn_q_w = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "weight")); - model.mm_model_attn_k_w = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "weight")); - model.mm_model_attn_v_w = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "weight")); - model.mm_model_attn_q_b = get_tensor(string_format(TN_RESAMPL_ATTN, "q", "bias")); - model.mm_model_attn_k_b = get_tensor(string_format(TN_RESAMPL_ATTN, "k", "bias")); - model.mm_model_attn_v_b = get_tensor(string_format(TN_RESAMPL_ATTN, "v", "bias")); - model.mm_model_attn_o_w = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "weight")); - model.mm_model_attn_o_b = get_tensor(string_format(TN_RESAMPL_ATTN, "out", "bias")); - model.mm_model_ln_post_w = get_tensor(string_format(TN_RESAMPL_LN, "post", "weight")); - model.mm_model_ln_post_b = get_tensor(string_format(TN_RESAMPL_LN, "post", "bias")); - // projector ffn - model.mm_1_w = get_tensor(string_format(TN_LLAVA_PROJ, 1, "weight")); - model.mm_1_b = get_tensor(string_format(TN_LLAVA_PROJ, 1, "bias")); - model.mm_2_w = get_tensor(string_format(TN_LLAVA_PROJ, 2, "weight")); - model.mm_2_b = get_tensor(string_format(TN_LLAVA_PROJ, 2, "bias")); - model.mm_input_norm_w = get_tensor(TN_MM_INP_NORM); - model.mm_input_norm_b = get_tensor(TN_MM_INP_NORM_B); - } break; default: GGML_ASSERT(false && "unknown projector type"); }