fix UMA detection on discrete GPUs. #17537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17536
Submitted as a draft for now as I do not have a Spark to hand to confirm
cudaGetDeviceProperties. I wrote a small CUDA to confirm thatprop.unifiedAddressing == 1on my discrete GPUs. This means it cannot be used to check if the device is a DGX Spark.https://developer.download.nvidia.com/compute/DevZone/docs/html/C/doc/html/group__CUDART__DEVICE_g5aa4f47938af8276f08074d09b7d520c.html -- these docs seem to suggest that this should be
prop.integratedinstead? This flag is 0 on my discrete GPUs.