ggml: use 'exists( const std::filesystem::path&, std::error_code&)' instead of 'exists( const std::filesystem::path&)' to enhance robustness #17653
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor existence checks for search paths using std::error_code to handle potential errors.
Update fs::exists to use std::error_code for error handling.
danbev
reviewed
Dec 1, 2025
github-actions
bot
added
the
ggml
Simplify existence check for search paths
am17an
reviewed
Dec 2, 2025
Co-authored-by: Aman Gupta <amangupta052@gmail.com>
danbev
reviewed
Dec 2, 2025
am17an
reviewed
Dec 2, 2025
danbev
approved these changes
Dec 3, 2025
Collaborator
|
@danbev merge? |
JayZenith
pushed a commit
to JayZenith/llama.cpp
that referenced
this pull request
Dec 7, 2025
…org#17653) * Improve error handling for search path existence checks Refactor existence checks for search paths using std::error_code to handle potential errors. * Improve cache file existence check with error code Update fs::exists to use std::error_code for error handling. * Simplify existence check for search paths Simplify existence check for search paths * Fix logging path in error message for posix_stat * Update ggml/src/ggml-backend-reg.cpp Co-authored-by: Aman Gupta <amangupta052@gmail.com> * Adapt to the coding standard --------- Co-authored-by: Aman Gupta <amangupta052@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use
exists( const std::filesystem::path& p), ifpcan't access(like: Permission denied), it will throwstd::filesystem::filesystem_errorto break the execution flow.