Skip to content

model: fix llama arch implementation #17665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

model: fix llama arch implementation #17665

merged 1 commit into from
Dec 1, 2025
+2 −0

Conversation

@giladgd
Copy link
Contributor

@giladgd giladgd commented Dec 1, 2025

No description provided.

@giladgd giladgd requested a review from CISC as a code owner December 1, 2025 20:14
@giladgd
Copy link
Contributor Author

giladgd commented Dec 1, 2025

@ngxson The llama arch seems to be broken since #17644, I noticed it since it failed tests that I run on some llama models.
I think you meant to copy the ml.get_key(LLM_KV_ATTENTION_LAYERNORM_RMS_EPS, hparams.f_norm_rms_eps); line instead of moving it.

ngxson
ngxson approved these changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah that was a mistake, thanks for the fix

@ngxson ngxson merged commit 00c361f into ggml-org:master Dec 1, 2025
60 of 65 checks passed
@giladgd giladgd deleted the fixLlamaArch branch December 1, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngxson ngxson ngxson approved these changes

@CISC CISC Awaiting requested review from CISC CISC is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giladgd @ngxson