Skip to content

webui: Stop generation from chat sidebar #17806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allozaur merged 2 commits into from
Dec 6, 2025
Merged

webui: Stop generation from chat sidebar #17806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b3c3f6
feat: Add stop generation button for Conversation Item
allozaur Dec 5, 2025
ad10b9f
chore: update webui build output
allozaur Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified tools/server/public/index.html.gz
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions tools/server/webui/src/lib/components/app/chat/ChatSidebar/ChatSidebar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import * as AlertDialog from '$lib/components/ui/alert-dialog';
import Input from '$lib/components/ui/input/input.svelte';
import { conversationsStore, conversations } from '$lib/stores/conversations.svelte';
import { chatStore } from '$lib/stores/chat.svelte';
import ChatSidebarActions from './ChatSidebarActions.svelte';

const sidebar = Sidebar.useSidebar();
Expand Down Expand Up @@ -98,6 +99,10 @@

await goto(`#/chat/${id}`);
}

function handleStopGeneration(id: string) {
chatStore.stopGenerationForChat(id);
}
</script>

<ScrollArea class="h-[100vh]">
Expand Down Expand Up @@ -132,6 +137,7 @@
onSelect={selectConversation}
onEdit={handleEditConversation}
onDelete={handleDeleteConversation}
onStop={handleStopGeneration}
/>
</Sidebar.MenuItem>
{/each}
Expand Down
53 changes: 51 additions & 2 deletions ...s/server/webui/src/lib/components/app/chat/ChatSidebar/ChatSidebarConversationItem.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script lang="ts">
import { Trash2, Pencil, MoreHorizontal, Download, Loader2 } from '@lucide/svelte';
import { Trash2, Pencil, MoreHorizontal, Download, Loader2, Square } from '@lucide/svelte';
import { ActionDropdown } from '$lib/components/app';
import * as Tooltip from '$lib/components/ui/tooltip';
import { getAllLoadingChats } from '$lib/stores/chat.svelte';
import { conversationsStore } from '$lib/stores/conversations.svelte';
import { onMount } from 'svelte';
Expand All @@ -12,6 +13,7 @@
onDelete?: (id: string) => void;
onEdit?: (id: string) => void;
onSelect?: (id: string) => void;
onStop?: (id: string) => void;
}

let {
Expand All @@ -20,6 +22,7 @@
onDelete,
onEdit,
onSelect,
onStop,
isActive = false
}: Props = $props();

Expand All @@ -38,8 +41,14 @@
onDelete?.(conversation.id);
}

function handleStop(event: Event) {
event.stopPropagation();
onStop?.(conversation.id);
}

function handleGlobalEditEvent(event: Event) {
const customEvent = event as CustomEvent<{ conversationId: string }>;

if (customEvent.detail.conversationId === conversation.id && isActive) {
handleEdit(event);
}
Expand Down Expand Up @@ -88,8 +97,28 @@
>
<div class="flex min-w-0 flex-1 items-center gap-2">
{#if isLoading}
<Loader2 class="h-3.5 w-3.5 shrink-0 animate-spin text-muted-foreground" />
<Tooltip.Root>
<Tooltip.Trigger>
<div
class="stop-button flex h-4 w-4 shrink-0 cursor-pointer items-center justify-center rounded text-muted-foreground transition-colors hover:text-foreground"
onclick={handleStop}
onkeydown={(e) => e.key === 'Enter' && handleStop(e)}
role="button"
tabindex="0"
aria-label="Stop generation"
>
<Loader2 class="loading-icon h-3.5 w-3.5 animate-spin" />

<Square class="stop-icon hidden h-3 w-3 fill-current text-destructive" />
</div>
</Tooltip.Trigger>

<Tooltip.Content>
<p>Stop generation</p>
</Tooltip.Content>
</Tooltip.Root>
{/if}

<!-- svelte-ignore a11y_click_events_have_key_events -->
<!-- svelte-ignore a11y_no_static_element_interactions -->
<span class="truncate text-sm font-medium" onclick={handleMobileSidebarItemClick}>
Expand Down Expand Up @@ -147,5 +176,25 @@
opacity: 1 !important;
}
}

.stop-button {
:global(.stop-icon) {
display: none;
}

:global(.loading-icon) {
display: block;
}
}

&:is(:hover) .stop-button {
:global(.stop-icon) {
display: block;
}

:global(.loading-icon) {
display: none;
}
}
}
</style>
14 changes: 9 additions & 5 deletions tools/server/webui/src/lib/stores/chat.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,13 +701,17 @@ class ChatStore {

if (!activeConv) return;

await this.savePartialResponseIfNeeded(activeConv.id);
await this.stopGenerationForChat(activeConv.id);
}

async stopGenerationForChat(convId: string): Promise<void> {
await this.savePartialResponseIfNeeded(convId);

this.stopStreaming();
this.abortRequest(activeConv.id);
this.setChatLoading(activeConv.id, false);
this.clearChatStreaming(activeConv.id);
this.clearProcessingState(activeConv.id);
this.abortRequest(convId);
this.setChatLoading(convId, false);
this.clearChatStreaming(convId);
this.clearProcessingState(convId);
}

/**
Expand Down