Skip to content

Global gitignore isn't taken into account #159

Closed
HerbCSO opened this Issue Mar 1, 2013 · 8 comments

5 participants

@HerbCSO
HerbCSO commented Mar 1, 2013

If I define a global gitignore file with the core.excludesfile option (see also https://help.github.com/articles/ignoring-files), ag doesn't take that into account. It only uses the git repo's .gitignore. It would be nice if it accounted for the global gitignore as well.

@cmr
cmr commented Mar 2, 2013

I'll write a patch for this too when I'm done #144

@moll
moll commented May 18, 2014

Any updates on this?

#175 indicates the global excludes file could be checked, but does that take the tilde to mark HOME (~/.gitignore) into account?

@ggreer ggreer added the ignore label Sep 26, 2014
@blueyed blueyed added a commit to blueyed/the_silver_searcher that referenced this issue Nov 23, 2014
@blueyed blueyed Use `--path` with `git config` to get the resolved excludesfile 2fb6372
@blueyed
blueyed commented Nov 23, 2014

@HerbCSO @moll
What does your core.excludesfile setting looks like? Are you using a ~ in it by any chance?

If so, #537 should fix this.

@moll
moll commented Nov 23, 2014

@blueyed: Yep, mine looks exactly like I point out in #159 (comment).

@HerbCSO
HerbCSO commented Nov 23, 2014

@blueyed actually my core.excludesfile is core.excludesfile=/Users/<username>/.cvsignore (yes, .cvsignore - for historical reasons and compatibility with other utilities... ;] ).

Seems that the version 0.27.0 I currently have installed is correctly handling the global gitignore for me, so no further issue for me, thanks. I'll leave it open for @moll though.

@blueyed
blueyed commented Nov 23, 2014

Thanks for reporting back.

This issue should then be closed in favor of #366 - which is exactly about the issue where the path is not resolved.

@moll
moll commented Nov 23, 2014

You guys will have to close this then. I can't. ;-)

@HerbCSO
HerbCSO commented Nov 23, 2014

OK, I'll close.

@HerbCSO HerbCSO closed this Nov 23, 2014
@blackb1rd blackb1rd added a commit to blackb1rd/the_silver_searcher that referenced this issue Mar 22, 2015
@blueyed blueyed Use `--path` with `git config` to get the resolved excludesfile 7ebbb99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.