Skip to content
Commits on Jan 5, 2009
  1. Author: Jeff King <peff@peff.net>

    The code feeds the results of $session->config('me') to
    sprintf as part of the format string. In practice, this is
    probably not a problem since hostnames don't contain percent
    signs. However, it triggers a taint warning in perl 5.10,
    making cram-md5 auth unusable.
    
    This patch rewrites the sprintf to insert the 'me' value
    using a %s format specifier.
    
    ---
    I don't know the usual practice for submitting patches to qpsmtpd, so
    please let me know if I should be doing something differently.
    
    I was a little confused by the test infrastructure, so no test, but
    hopefully this change is Obviously Correct. I can trigger it on my
    Debian testing and unstable boxen with just this plugin:
    
      sub hook_auth_cram_md5 {
          return (DECLINED);
      }
    
    which generates this in the log:
    
      1732 XX: Insecure dependency in sprintf while running with -T switch at
           lib/Qpsmtpd/Auth.pm line 63, <STDIN> line 3.
      ./qpsmtpd[1732]: command 'auth' failed unexpectedly (Bad file descriptor)
    
    
    
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@967 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Jan 5, 2009
Commits on Jan 2, 2009
  1. Ignore leading/trailing whitespace in config files

    Author: Henry Baragar <Henry.Baragar@instantiated.ca>
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@966 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Jan 2, 2009
Commits on Dec 31, 2008
  1. Trailing whitespace cleanup

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@965 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Dec 31, 2008
  2. Allow configuration of spool_dir permissions

    Author: Jared Johnson <jaredj@nmgi.com>
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@964 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Dec 31, 2008
  3. Allow local sites to override the definition of an email address.

    Author: Jared Johnson <jaredj@nmgi.com>
    
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@963 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Dec 31, 2008
  4. qpsmtpd (x)inetd: fix Can't call method "connected" on an undefined v…

    …alue at lib/Qpsmtpd/TcpServer.pm line 174.
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@962 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Dec 31, 2008
Commits on Dec 22, 2008
  1. update to latest commit (connection->local_*)

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@961 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Dec 22, 2008
Commits on Dec 15, 2008
  1. async: add connection->local_ip, connection->local_port

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@960 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Dec 15, 2008
Commits on Nov 16, 2008
  1. keep the square brackets around the IP as "remote_host" if the revers…

    …e lookup failed
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@957 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Nov 16, 2008
Commits on Nov 4, 2008
  1. "chomp" DEBUG output - for logging/file

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@956 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Nov 4, 2008
Commits on Oct 27, 2008
  1. Support returning 0 values in config files (always worked on the seco…

    …nd call
    
    due to the cache, but would return undef on the first call)
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@955 958fd67b-6ff1-0310-b445-bb7760255be9
    msergeant committed Oct 27, 2008
Commits on Oct 24, 2008
  1. forkserver: fix wrong detection of closed connection

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@954 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Oct 24, 2008
Commits on Oct 21, 2008
  1. prepare for 0.90, part 2 - hopefully [:-)] all important changes from…

    … "svn log"
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@953 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Oct 21, 2008
  2. prepare releasing v0.90 - update STATUS file to not have version numb…

    …ers; clean up a little
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@952 958fd67b-6ff1-0310-b445-bb7760255be9
    ask committed Oct 21, 2008
Commits on Oct 7, 2008
  1. Someone needs to remember to run `make manifest` more often, to catch

    things added and deleted.  Most of this change is just reordering to be
    alphabetical, but it does remove the old select-server stuff, adds one
    new test file and a couple of new plugins.
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@951 958fd67b-6ff1-0310-b445-bb7760255be9
    jpeacock committed Oct 7, 2008
  2. Sometimes Perl is too smart for its own good. Precedence rules sux...

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@950 958fd67b-6ff1-0310-b445-bb7760255be9
    jpeacock committed Oct 7, 2008
Commits on Sep 30, 2008
  1. Lower log level of rcpt/from addresses

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@949 958fd67b-6ff1-0310-b445-bb7760255be9
    msergeant committed Sep 30, 2008
Commits on Sep 29, 2008
  1. Diego warned me that the construct I used, signal sent to negative PID,

    is not portable. Replaced it with his construct, the negative signal.
    Also added the short sleep after socket close, as in his patch.
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@948 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 29, 2008
Commits on Sep 26, 2008
  1. Fix bug in -async where the body_file (via body_filename) wouldn't ha…

    …ve the headers in it.
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@947 958fd67b-6ff1-0310-b445-bb7760255be9
    msergeant committed Sep 26, 2008
  2. Fix to check client is writable before writing to it.

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@946 958fd67b-6ff1-0310-b445-bb7760255be9
    msergeant committed Sep 26, 2008
  3. Fix to check all MX hosts, not just the first

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@945 958fd67b-6ff1-0310-b445-bb7760255be9
    msergeant committed Sep 26, 2008
Commits on Sep 4, 2008
  1. To improve the shutdown of parent and children, send the exiting signal

    to the process group (maybe %children is not up to date on very busy
    systems).
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@943 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
  2. Clean up exit codes.

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@942 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
  3. Detect and reset locked shared memory.

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@941 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
  4. Untaint the value of the --interface option.

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@940 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
  5. Inside the main loop skip the sleep when children have exited. Instead,

    proceed directly to the pool adjustment. While at it, simplify processing
    by moving the update of shared memory from the SIGCHLD handler to the
    main loop.
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@939 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
  6. Detach and daemonize only after reading the configuration and loading

    the plugins, to give the init scripts a chance to detect failed startups
    due to broken configuration or plugins.
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@938 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
  7. Close the SSL socket created by duplicating the connection file

    descriptor. This allows the server to close the connection file
    descriptor without getting errors like:
    
      Can't call method "close" on an undefined value at 
      /usr/share/perl5/IO/Socket/SSL.pm line 780.
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@937 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Sep 4, 2008
Commits on Aug 5, 2008
  1. Set the Return-Path header when queuing into maildir mailboxes.

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@936 958fd67b-6ff1-0310-b445-bb7760255be9
    radu committed Aug 5, 2008
Commits on Jul 31, 2008
  1. update documentation (issue #26)

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@935 958fd67b-6ff1-0310-b445-bb7760255be9
    ask committed Jul 31, 2008
Commits on Jul 4, 2008
  1. Recreate the Geo::IP object for each message.

    (Otherwise it will hold the underlying database file handle open, and it doesn't like when that file changes underneath it.)
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@933 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Jul 4, 2008
  2. Fix missing capture group

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@932 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Jul 4, 2008
Commits on Jun 28, 2008
  1. queue/maildir - multi user / multi domain support added

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@931 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Jun 28, 2008
Commits on Jun 16, 2008
  1. - Fix duplication of com|net|org|biz|info

    - Fix broken travel (missing |)
    Thanks to Guy Hulbert for the catch.
    
    
    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@929 958fd67b-6ff1-0310-b445-bb7760255be9
    robert committed Jun 16, 2008
Commits on Jun 15, 2008
  1. update Changes: SIGHUP reload for prefork/forkserver

    git-svn-id: http://svn.perl.org/qpsmtpd/trunk@928 958fd67b-6ff1-0310-b445-bb7760255be9
    vetinari committed Jun 15, 2008
Something went wrong with that request. Please try again.