New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rebindable fail work with overloaded strings #168

Merged
merged 2 commits into from Oct 21, 2018

Conversation

Projects
None yet
5 participants
@shayne-fletcher-da
Copy link
Contributor

shayne-fletcher-da commented Sep 17, 2018

We propose that string literals generated by GHC and passed to user defined functions should have fromString applied. The only instance of such GHC generated strings we are aware of is via fail, so we propose to fix that case.

Rendered

@shayne-fletcher-da shayne-fletcher-da force-pushed the shayne-fletcher-da:fail-rebindable-with-overloaded-strings branch from 51a947f to 9ec4fde Sep 17, 2018

@nomeata

This comment has been minimized.

Copy link
Contributor

nomeata commented Sep 17, 2018

I am sympathetic. I would be least surprised if the implicit string in the generated code would behave like a literal.

@ndmitchell

This comment has been minimized.

Copy link
Contributor

ndmitchell commented Sep 18, 2018

To state my opinion, I reviewed the proposal with @shayne-fletcher-da before submission, it feels like a bug fix to me, and I'm in favour :)

Ping @vincenthz, who writes the foundation library. I imagine this might be useful for him, or he might have opinions on it.

@vincenthz

This comment has been minimized.

Copy link

vincenthz commented Sep 20, 2018

I looked at this a bit diagonally, but that seems just a bug related to RebindableSyntax (similar to some of the recent one linked to the far reaching consequences). On the face value, that should keep RedindableSyntax working as expected, so 👍 from me.

@ndmitchell

This comment has been minimized.

Copy link
Contributor

ndmitchell commented Sep 24, 2018

It seems that there are no objections, despite posting to Twitter no real comments, so can we get a steering committee vote? In the meantime there is now a patch, which will go through the standard Phab workflow once the proposal is approved.

@ndmitchell

This comment has been minimized.

Copy link
Contributor

ndmitchell commented Oct 21, 2018

Is anything more required to trigger the committee review?

@nomeata

This comment has been minimized.

Copy link
Contributor

nomeata commented Oct 21, 2018

The review has been triggered by my mail to the list, and is now waiting for people to speak up. If nobody speaks up I'll accept this. I can probably do that already, but breakfast first.

@nomeata nomeata merged commit 0272579 into ghc-proposals:master Oct 21, 2018

nomeata added a commit that referenced this pull request Oct 21, 2018

@nomeata

This comment has been minimized.

Copy link
Contributor

nomeata commented Oct 21, 2018

Done, and thanks for the ping.

@ndmitchell

This comment has been minimized.

Copy link
Contributor

ndmitchell commented Oct 21, 2018

Thanks! Phab submission to follow soon

@bravit bravit added the Proposal label Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment