Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Simplify specifying that some libraries need to use the build.* rules

Now you just add them to SUBDIRS_BUILD instead of SUBDIRS.
  • Loading branch information...
1 parent d7d7558 commit 20d0ce2f990864da1a8330c363c9bfd7afa69dbd @igfoo igfoo committed
Showing with 9 additions and 6 deletions.
  1. +9 −6 libraries/Makefile
15 libraries/Makefile
@@ -74,9 +74,11 @@ ifeq "$(GhcLibsWithObjectIO)" "YES"
SUBDIRS += $(wildcard ObjectIO)
SUBDIRS += $(wildcard parallel)
-SUBDIRS += $(wildcard ndp)
+SUBDIRS_BUILD += $(wildcard ndp)
# -----------------------------------------------------------------------------
@@ -293,9 +295,9 @@ stamp/$(CONFIGURE_STAMP_EXTRAS).%: %/setup/Setup
# needs to be done. However, we're careful not to overwrite GNUmakefile
# if it hasn't changed, so that dependency-generation isn't forced
# every time.
-# I doubt that the makefile way will work with ndp, so filter it out and use
-# a rule below to call build.library.ndp instead
-$(foreach SUBDIR,$(filter-out ndp,$(SUBDIRS)),make.library.$(SUBDIR)):\
+# Packages in $(SUBDIRS_BUILD) need to use the build.* rules instead of
+# make.*, so filter them out and use an alternate rule below instead.
+$(foreach SUBDIR,$(filter-out $(SUBDIRS_BUILD),$(SUBDIRS)),make.library.$(SUBDIR)):\
make.library.%: stamp/$(CONFIGURE_STAMP_EXTRAS).% \
%/setup/Setup ifBuildable/ifBuildable installPackage/installPackage
if $(IFBUILDABLE) $*; then \
@@ -310,8 +312,9 @@ make.library.%: stamp/$(CONFIGURE_STAMP_EXTRAS).% \
MAKEFILE_LOCAL = $(FPTOOLS_TOP_ABS)/libraries/Makefile.local
-# Hack for ndp, as described above
-make.library.ndp: build.library.ndp
+# Alternate rule, as described above
+$(foreach SUBDIR,$(SUBDIRS_BUILD),make.library.$(SUBDIR)):\
+make.library.%: build.library.%
# Build the library using 'setup build' (not the default)
$(foreach SUBDIR,$(SUBDIRS),build.library.$(SUBDIR)):\

0 comments on commit 20d0ce2

Please sign in to comment.
Something went wrong with that request. Please try again.