New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift: can't shift that many #22

Closed
lepe opened this Issue May 23, 2016 · 9 comments

Comments

Projects
None yet
6 participants
@lepe

lepe commented May 23, 2016

It seems that RESP_BODY content changed.

(Line 310)

DOMAIN_CHALLENGE="sed -e '/"http-01"/ ! d; s/.*{\([^}]*"type":"http-01"[^}]*\)}.*/\1/' "$RESP_BODY""

But, if you see the content, there is a space: "type":(HERE)"http-01". The same applies to: DOMAIN_TOKEN and DOMAIN_URI

Which makes the regular expression to fail:

push response for "type":
./letsencrypt.sh: 374: shift: can't shift that many
@llaumgui

This comment has been minimized.

Show comment
Hide comment
@llaumgui

llaumgui Jun 8, 2016

Same issue

llaumgui commented Jun 8, 2016

Same issue

@maxdwit

This comment has been minimized.

Show comment
Hide comment
@maxdwit

maxdwit Jun 18, 2016

correct. same problem.

maxdwit commented Jun 18, 2016

correct. same problem.

@oddtwelve

This comment has been minimized.

Show comment
Hide comment
@oddtwelve

oddtwelve Jun 23, 2016

Same here :-( shift: 657: can't shift that many

oddtwelve commented Jun 23, 2016

Same here :-( shift: 657: can't shift that many

@bruncsak

This comment has been minimized.

Show comment
Hide comment
@bruncsak

bruncsak Jun 24, 2016

Please try my version. I probably fixed this issue. Please give feedback: let us know.

bruncsak commented Jun 24, 2016

Please try my version. I probably fixed this issue. Please give feedback: let us know.

@maxdwit

This comment has been minimized.

Show comment
Hide comment
@maxdwit

maxdwit Jun 24, 2016

Tried your version.
unhandled response while checking verification status of mydomain.com
HTTP/1.1 202 Accepted
I've verified if the displayed "url": is in fact pointing to mydomain.com/.well-known/acme-challenge/xxxxx

maxdwit commented Jun 24, 2016

Tried your version.
unhandled response while checking verification status of mydomain.com
HTTP/1.1 202 Accepted
I've verified if the displayed "url": is in fact pointing to mydomain.com/.well-known/acme-challenge/xxxxx

@bruncsak

This comment has been minimized.

Show comment
Hide comment
@bruncsak

bruncsak Jun 25, 2016

It is fixed now. Could you have an other trial please?

bruncsak commented Jun 25, 2016

It is fixed now. Could you have an other trial please?

@maxdwit

This comment has been minimized.

Show comment
Hide comment
@maxdwit

maxdwit Jun 27, 2016

Works like a charm! Thanks for fixing it brunsak!

maxdwit commented Jun 27, 2016

Works like a charm! Thanks for fixing it brunsak!

@oddtwelve

This comment has been minimized.

Show comment
Hide comment
@oddtwelve

oddtwelve Jun 27, 2016

Thanks, bruncsak. It is working!

oddtwelve commented Jun 27, 2016

Thanks, bruncsak. It is working!

@sudoman

This comment has been minimized.

Show comment
Hide comment
@sudoman

sudoman Jul 1, 2016

Contributor

@bruncsak It works for me. :D

Contributor

sudoman commented Jul 1, 2016

@bruncsak It works for me. :D

@lepe lepe closed this Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment