Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current #HEAD bad compiles @foo #30

Open
trunda opened this issue Mar 9, 2014 · 4 comments
Open

Current #HEAD bad compiles @foo #30

trunda opened this issue Mar 9, 2014 · 4 comments

Comments

@trunda
Copy link

trunda commented Mar 9, 2014

Hi there, current head compiles this:

@bar.contains(@foo) to get$(this, 'bar').contains(this.foo);. It should be get$(this, 'bar').contains(get$(this, 'foo'));

@trunda
Copy link
Author

trunda commented Mar 9, 2014

I guess it is because commit 2134700, where is added this code.

@ghempton
Copy link
Owner

ghempton commented Mar 9, 2014

Looks like it could be from this line: 2134700c2d#diff-097a81dfc786f3a3aa0d594b496ea92bR217. That is probably due to a bad merge from CoffeeScriptRedux. I don't have time to look at this until later, do you have a minute to see if that fixes it?

@BenV
Copy link
Contributor

BenV commented Mar 11, 2014

It actually appears to be this line: 6b0fa13#diff-097a81dfc786f3a3aa0d594b496ea92bR647

If I remove that /contextVar it starts working properly again. I don't have enough pegjs expertise to try to write a test case or anything, but hopefully this helps.

@ghempton
Copy link
Owner

Do you have time to create a PR that removes that line?

BenV pushed a commit to BenV/ember-script that referenced this issue Mar 11, 2014
@BenV BenV mentioned this issue Mar 11, 2014
ghempton added a commit that referenced this issue Mar 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants