Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix arguments #52

merged 1 commit into from Jun 1, 2019


None yet
2 participants
Copy link

commented Jun 1, 2019


This PR fixes the arguments of the following functions which are expecting only 1 argument:

Breaking changes



Make sure you check all the boxes. You can omit items that are not applicable.

  • Implementation for both <Async> and useAsync()
  • Added / updated the unit tests
  • Added / updated the documentation
  • Updated the PropTypes
  • Updated the TypeScript type definitions

This comment has been minimized.

Copy link

commented Jun 1, 2019

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
  Coverage   99.65%   99.65%           
  Files           7        7           
  Lines         582      582           
  Branches      122      122           
  Hits          580      580           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4255897...daa6b1f. Read the comment docs.

@noelyoo noelyoo force-pushed the noelyoo:fix-arguments branch from 248195b to 04ff9ac Jun 1, 2019

@noelyoo noelyoo force-pushed the noelyoo:fix-arguments branch from 04ff9ac to daa6b1f Jun 1, 2019

@noelyoo noelyoo changed the title test(useAsync.spec): fix arguments test: fix arguments Jun 1, 2019

Copy link

left a comment

Looks good, thanks for cleaning that up!

@ghengeveld ghengeveld merged commit e02ee4c into ghengeveld:master Jun 1, 2019

4 checks passed

Travis CI - Pull Request Build Passed
codecov/patch Coverage not affected when comparing 4255897...daa6b1f
codecov/project 99.65% remains the same compared to 4255897
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.