New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsequent pins failing in a multi-pin reservation don't unreserve the previous #312

Closed
Palomino34 opened this Issue Jun 13, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Palomino34
Contributor

Palomino34 commented Jun 13, 2018

We are having a lot of something like:

if (!STM32F4_GpioInternal_OpenPin(sda.number) || !STM32F4_GpioInternal_OpenPin(scl.number))
        return TinyCLR_Result::SharingViolation;

if sda was reserved successfully but scl failed then sda will be reserved forever.

Similar to allocate memory tx and rx.

@Palomino34 Palomino34 added the question label Jun 13, 2018

@Palomino34 Palomino34 added this to the v1.0.0 milestone Jun 13, 2018

@Palomino34 Palomino34 self-assigned this Jun 13, 2018

@Arke64 Arke64 added bug and removed question labels Jun 13, 2018

@Arke64 Arke64 modified the milestones: v1.0.0, v1.0.0-preview1 Jun 13, 2018

@Arke64 Arke64 changed the title from Check reserved multi pins to Subsequent pins failing in a multi-pin reservation don't unreserve the previous Jun 13, 2018

@Arke64 Arke64 modified the milestones: v1.0.0-preview2, Backlog Sep 25, 2018

@Arke64 Arke64 modified the milestones: Backlog, v1.0.0-preview3 Oct 4, 2018

Palomino34 added a commit that referenced this issue Oct 5, 2018

@Arke64 Arke64 closed this in #482 Oct 9, 2018

Arke64 added a commit that referenced this issue Oct 9, 2018

Merge pull request #482 from ghi-electronics/#312_ReleasePinOrMemoryI…
…fRequesttaskfailed

#312 release pin or memory if requesttaskfailed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment