New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time to event that posted from native to managed. #368

Closed
Palomino34 opened this Issue Jul 31, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@Palomino34
Contributor

Palomino34 commented Jul 31, 2018

Example Gpio

interopManager->RaiseEvent(interopManager, "GHIElectronics.TinyCLR.NativeEventNames.Gpio.PinChanged", self->ApiInfo->Name, (uint64_t)pin, (uint64_t)(edge == TinyCLR_Gpio_PinChangeEdge::RisingEdge), 0, 0);

The last param should be time, temporary set to zero.

Same issue for Uart, Can.

@Palomino34 Palomino34 added the bug label Jul 31, 2018

@Palomino34 Palomino34 added this to the v1.0.0-preview1 milestone Jul 31, 2018

@Palomino34 Palomino34 self-assigned this Jul 31, 2018

@Palomino34

This comment has been minimized.

Show comment
Hide comment
@Palomino34

Palomino34 Aug 7, 2018

Contributor

Managed driver ignore time, aslo in native, adding more functions to get time for CAN, GPIO, UART... will increase size.

Contributor

Palomino34 commented Aug 7, 2018

Managed driver ignore time, aslo in native, adding more functions to get time for CAN, GPIO, UART... will increase size.

@Palomino34 Palomino34 closed this Aug 7, 2018

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Aug 7, 2018

Member

We don't currently use it in our handlers but the user might. Either way we can push back.

Member

Arke64 commented Aug 7, 2018

We don't currently use it in our handlers but the user might. Either way we can push back.

@Palomino34

This comment has been minimized.

Show comment
Hide comment
@Palomino34

Palomino34 Aug 7, 2018

Contributor

Just rework, for an event take around 60 bytes. We have Uart x 3 events + Can x 2 events + gpio x 1 event = 360 bytes more. Temporary not implement.

Contributor

Palomino34 commented Aug 7, 2018

Just rework, for an event take around 60 bytes. We have Uart x 3 events + Can x 2 events + gpio x 1 event = 360 bytes more. Temporary not implement.

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Aug 7, 2018

Member

This is for preview 2, don't need to worry about now.

Member

Arke64 commented Aug 7, 2018

This is for preview 2, don't need to worry about now.

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Sep 17, 2018

Member

This is fixed with the other PR to add time to the native event handlers

Member

Arke64 commented Sep 17, 2018

This is fixed with the other PR to add time to the native event handlers

@Arke64 Arke64 closed this Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment