New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded device configuration from build.bat #6

Closed
kodfilemon opened this Issue Jul 14, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@kodfilemon

kodfilemon commented Jul 14, 2017

It is possible to refactoring build.bat?
Maybe better way (even temporary) is move set parameters from build.bat to every Devices port.
For example in Devices\FEZ directory create args.txt file with content:

ProcessorPart=STM32F4
ProcessorArchitecture=CortexM4
ImageGenParameters=0x884DED08 0x3671259A 0x08008000 0x00038000

And in build.bat in place of IF ELSE tree section:

SET ARGSFILE=%ScriptRoot%\Devices\%Device%\args.txt
IF EXIST "%ARGSFILE%" (
  for /f "delims=" %%A in ('type "%ARGSFILE%"') do (
     SET %%A
) 
) ELSE (
  ECHO Unsupported device passed: %Device%
  GOTO :EOF
)

In this way is simplify create new port (copy) without touching build.bat.

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Jul 14, 2017

Member

There's still a lot of work needed in build.bat, but this would be a quick and easy change that we're open to.

Member

Arke64 commented Jul 14, 2017

There's still a lot of work needed in build.bat, but this would be a quick and easy change that we're open to.

@Arke64 Arke64 added this to the v0.6.0 milestone Jul 14, 2017

@Arke64 Arke64 added the new feature label Jul 14, 2017

@Arke64 Arke64 changed the title from Question: build.bat refactoring to Remove hard coded device configuration from build.bat Jul 14, 2017

@Arke64 Arke64 self-assigned this Jul 31, 2017

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Aug 3, 2017

Member

Done. It's actually been split up into three different files now, one each for the device, target, and core.

Member

Arke64 commented Aug 3, 2017

Done. It's actually been split up into three different files now, one each for the device, target, and core.

@Arke64 Arke64 closed this Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment