New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUCLEO-F401RE device. #47

Merged
merged 3 commits into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@matsujirushi
Contributor

matsujirushi commented Sep 3, 2017

No description provided.

@Arke64 Arke64 changed the base branch from master to dev Sep 5, 2017

@Arke64

Thanks for the contribution! There's just a few minor changes needed to the DeviceSelector file. I did change the target branch to dev. Target that branch in future PRs. We'll also need a signed contributor license agreement from you in order to accept this PR. I'll get a link to you shortly.

Show outdated Hide outdated Devices/NUCLEO-F401RE/DeviceSelector.h
Show outdated Hide outdated Devices/NUCLEO-F401RE/DeviceSelector.h
Show outdated Hide outdated Devices/NUCLEO-F401RE/DeviceSelector.h
Show outdated Hide outdated Devices/NUCLEO-F401RE/DeviceSelector.h
Show outdated Hide outdated Devices/NUCLEO-F401RE/DeviceSelector.h
Show outdated Hide outdated Devices/NUCLEO-F401RE/DeviceSelector.h

@Arke64 Arke64 added the blocked label Sep 5, 2017

@matsujirushi

This comment has been minimized.

Show comment
Hide comment
@matsujirushi

matsujirushi Sep 5, 2017

Contributor

Thank you for your message.
I'll try.

My plan is remove USB debugging because NUCLEO has UART-USB converter. (I/F chip)

Contributor

matsujirushi commented Sep 5, 2017

Thank you for your message.
I'll try.

My plan is remove USB debugging because NUCLEO has UART-USB converter. (I/F chip)

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Sep 5, 2017

Member

When ready you can download the CLA form from https://github.com/ghi-electronics/TinyCLR-Ports/blob/dev/README.md#contributing

Please sign it, scan and upload it, then return to us at the specified address.

Member

Arke64 commented Sep 5, 2017

When ready you can download the CLA form from https://github.com/ghi-electronics/TinyCLR-Ports/blob/dev/README.md#contributing

Please sign it, scan and upload it, then return to us at the specified address.

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Sep 5, 2017

Member

Even though the nucleo has a converter to enable serial debugging, if it can also be used for USB debugging, we want to keep that as an option for the user -- even if it isn't the default.

Member

Arke64 commented Sep 5, 2017

Even though the nucleo has a converter to enable serial debugging, if it can also be used for USB debugging, we want to keep that as an option for the user -- even if it isn't the default.

@matsujirushi

This comment has been minimized.

Show comment
Hide comment
@matsujirushi

matsujirushi Sep 9, 2017

Contributor

I apply some issues. matsujirushi@f52ba98

I have a problem.
I don't have USB PID&VID because I am not STMicro.
Please advise.

Contributor

matsujirushi commented Sep 9, 2017

I apply some issues. matsujirushi@f52ba98

I have a problem.
I don't have USB PID&VID because I am not STMicro.
Please advise.

@valoni

This comment has been minimized.

Show comment
Hide comment
@valoni

valoni Sep 9, 2017

Contributor

Do not worry about USB PID&USB (use that ones defined from GHI) since pa2/pa3 you defined to be used as serial you may use with any vendor uart/serial to usb converter too such are ftdrl ,pl2303 ,ch340 etc(because of external pins exist)...

Contributor

valoni commented Sep 9, 2017

Do not worry about USB PID&USB (use that ones defined from GHI) since pa2/pa3 you defined to be used as serial you may use with any vendor uart/serial to usb converter too such are ftdrl ,pl2303 ,ch340 etc(because of external pins exist)...

@matsujirushi

This comment has been minimized.

Show comment
Hide comment
@matsujirushi

matsujirushi Sep 10, 2017

Contributor

I think we need to choice we can change LMODE_PIN(ENABLE usb debugging or DISABLE) or NOT.

I want to choice NOT because NUCLEO-F401RE have not USB-OTG connector and I don't have PID&VID.
Do you think that? @valoni @Arke64

Contributor

matsujirushi commented Sep 10, 2017

I think we need to choice we can change LMODE_PIN(ENABLE usb debugging or DISABLE) or NOT.

I want to choice NOT because NUCLEO-F401RE have not USB-OTG connector and I don't have PID&VID.
Do you think that? @valoni @Arke64

@Arke64

This comment has been minimized.

Show comment
Hide comment
@Arke64

Arke64 Sep 11, 2017

Member

For now, go ahead and use the same VID and PID. We will have some guidance soon for what values you should use going forward.

@valoni reported an issue around which debugger to use and #53 tracks that issue. The defines will probably be changed to "USE_MODE_PIN", "USE_UART_DEBUGGER", "USE_USB_DEBUGGER" instead of how it is setup now.

Member

Arke64 commented Sep 11, 2017

For now, go ahead and use the same VID and PID. We will have some guidance soon for what values you should use going forward.

@valoni reported an issue around which debugger to use and #53 tracks that issue. The defines will probably be changed to "USE_MODE_PIN", "USE_UART_DEBUGGER", "USE_USB_DEBUGGER" instead of how it is setup now.

@Arke64

Arke64 approved these changes Sep 11, 2017

@Arke64 Arke64 merged commit 71013ff into ghi-electronics:dev Sep 11, 2017

@Arke64 Arke64 removed the blocked label Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment