SQLite3Adapter#type_cast should not mutate arguments

ghiculescu · Oct 28, 2012 · b5133d0 · b5133d0
1 parent 852e376
commit b5133d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
@@ -251,7 +251,7 @@ def type_cast(value, column) # :nodoc:
         value = super
         if column.type == :string && value.encoding == Encoding::ASCII_8BIT
           logger.error "Binary data inserted for `string` type on column `#{column.name}`" if logger
-          value.encode! 'utf-8'
+          value = value.encode Encoding::UTF_8
         end
         value
       end

diff --git a/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb b/activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
@@ -154,6 +154,12 @@ def test_quote_binary_column_escapes_it
         DualEncoding.connection.drop_table('dual_encodings')
       end
 
+      def test_type_cast_should_not_mutate_encoding
+        name  = 'hello'.force_encoding(Encoding::ASCII_8BIT)
+        owner = Owner.create(name: name)
+        assert_equal Encoding::ASCII_8BIT, name.encoding
+      end
+
       def test_execute
         @conn.execute "INSERT INTO items (number) VALUES (10)"
         records = @conn.execute "SELECT * FROM items"