Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 22, 2023

  • fixes issue brought in comment under issue #1092
  • there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
  • the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
    • this is fixed in Slickgrid-Universal PR 938

TODOs

  • requires a new Slickgrid-Universal version
  • add new unit tests coverage

Using all 3 extensions (RowMove, RowSelection & RowDetail) now works correctly when used with Grid Presets

the following presets now works

presets: {
  columns: [
    { columnId: 'title' },
    { columnId: 'duration' },
    { columnId: 'start' },
    { columnId: 'finish' },
    { columnId: 'percent2' },
    { columnId: 'effort-driven' }
  ]
}

is now correctly bringing back all 3 dynamically created columns as shown below
image

2nd Bug will be fixed in Slickgrid-Universal PR 938

image

- fixes issue brought in comment under issue #1092
- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when columns presets are used
- the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1116 (0285916) into master (d417e75) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          911       925   +14     
  Branches       298       307    +9     
=========================================
+ Hits           911       925   +14     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 2e83d98 into master Mar 23, 2023
@ghiscoding ghiscoding deleted the bugfix/dynamic-columns-with-presets branch March 23, 2023 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants