Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 28, 2019

  • also rename all CRUD methods to more simple names, however we keep previous method name with a @deprecated comment.

Ghislain Beaulac added 2 commits May 28, 2019 12:08
- also rename all CRUD methods to more simple names, however we keep previous method name with a @deprecated comment.
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #208 into master will increase coverage by 0.74%.
The diff coverage is 67.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   40.81%   41.55%   +0.74%     
==========================================
  Files         146      146              
  Lines        6786     6839      +53     
  Branches     2239     2262      +23     
==========================================
+ Hits         2769     2841      +72     
+ Misses       4014     3996      -18     
+ Partials        3        2       -1
Impacted Files Coverage Δ
...modules/angular-slickgrid/services/grid.service.ts 45.53% <67.95%> (+24.81%) ⬆️
...dules/angular-slickgrid/services/filter.service.ts 17.38% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43db316...eb2ec1f. Read the comment docs.

@ghiscoding ghiscoding merged commit 5ce8b84 into master May 29, 2019
@ghiscoding ghiscoding deleted the feat/upsert branch May 30, 2019 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants