Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • the backend services were using SlickGrid getColumns to get the column definitions but that returns only the visible columns, however we should be able to preset filters on hidden columns and also expect all columns to be queried (it's not because the column is hidden that we shouldn't be able to filter it and query it)

- the backend services were using SlickGrid `getColumns` to get the column definitions but that returns only the visible columns, however we should be able to preset filters on hidden columns and also expect all columns to be queried (it's not because the column is hidden that we shouldn't be able to filter it and query it)
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #768 (e10f723) into master (10e756c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          160       160           
  Lines        11144     11145    +1     
  Branches      3980      3982    +2     
=========================================
+ Hits         11144     11145    +1     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...ules/angular-slickgrid/services/graphql.service.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/services/grid-odata.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e756c...e10f723. Read the comment docs.

@ghiscoding ghiscoding merged commit e363658 into master May 21, 2021
@ghiscoding ghiscoding deleted the bugfix/backend-presets-filters-with-hidden-column branch May 21, 2021 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants