Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • fixes #949
  • Row Detail extension columns were offset by 1 column (ie, clicking on 2nd column would sort 1st column), internally the RowDetail extension has to be instantiated a little bit more early within Angular-Slickgrid for it to properly sync columns and so on
  • added couple more Cypress E2E tests to cover the Sorting icons to be displayed under the expected column

- fixes #949
- Row Detail extension columns were offset by 1 column (ie, clicking on 2nd column would sort 1st column), internally the RowDetail extension has to be instantiated a little bit more early within Angular-Slickgrid for it to properly sync columns and so on
- added couple more Cypress E2E tests to cover the Sorting icons to be displayed under the expected column
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #950 (09cc298) into master (7be3443) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          981       979    -2     
  Branches       329       329           
=========================================
- Hits           981       979    -2     
Impacted Files Coverage Δ
...angular-slickgrid/extensions/slickRowDetailView.ts 100.00% <ø> (ø)
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be3443...09cc298. Read the comment docs.

@ghiscoding ghiscoding merged commit 495c6cc into master Jul 5, 2022
@ghiscoding ghiscoding deleted the bugfix/row-detail branch July 5, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Row detail view + sorting + filtering + expanding Headline / master

2 participants