This repository was archived by the owner on Jun 1, 2025. It is now read-only.
fix(pagination): disabled page buttons should not be clickable #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 148 148
Lines 9566 9574 +8
Branches 3332 3202 -130
==========================================
+ Hits 9566 9574 +8
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the Bootstrap styling applied to the DOM element does not block clicks from it, the reason is because they are in fact
hreflinks which cannot by disabled (according to w3c specs), so it's better to check if action is enabled before proceeding with clicks