From 4ffc69457633e99aef71c7879087e4e2919af22e Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Sat, 3 Dec 2022 19:24:27 -0500 Subject: [PATCH] fix: few more small examples fixes --- src/examples/slickgrid/example1.tsx | 17 +++++++++-------- src/examples/slickgrid/example10.tsx | 2 +- src/examples/slickgrid/example11.tsx | 2 +- src/examples/slickgrid/example12.tsx | 2 +- src/examples/slickgrid/example13.tsx | 2 +- src/examples/slickgrid/example14.tsx | 2 +- src/examples/slickgrid/example15.tsx | 2 +- src/examples/slickgrid/example16.tsx | 2 +- src/examples/slickgrid/example17.tsx | 4 ++-- src/examples/slickgrid/example18.tsx | 2 +- src/examples/slickgrid/example19.tsx | 6 +++--- src/examples/slickgrid/example2.tsx | 18 ++++++------------ src/examples/slickgrid/example20.tsx | 2 +- src/examples/slickgrid/example21.tsx | 2 +- src/examples/slickgrid/example22.tsx | 2 +- src/examples/slickgrid/example23.tsx | 2 +- src/examples/slickgrid/example24.tsx | 2 +- src/examples/slickgrid/example25.tsx | 2 +- src/examples/slickgrid/example26.tsx | 2 +- src/examples/slickgrid/example27.tsx | 2 +- src/examples/slickgrid/example28.tsx | 2 +- src/examples/slickgrid/example29.tsx | 2 +- src/examples/slickgrid/example3.tsx | 2 ++ src/examples/slickgrid/example30.tsx | 2 +- src/examples/slickgrid/example31.tsx | 4 +--- src/examples/slickgrid/example32.tsx | 2 +- src/examples/slickgrid/example33.tsx | 2 +- src/examples/slickgrid/example34.tsx | 2 +- src/examples/slickgrid/example4.tsx | 2 +- src/examples/slickgrid/example5.tsx | 4 +--- src/examples/slickgrid/example6.tsx | 2 +- src/examples/slickgrid/example7.tsx | 2 +- src/examples/slickgrid/example8.tsx | 2 +- src/examples/slickgrid/example9.tsx | 2 +- .../components/slickgrid-react.tsx | 5 +---- 35 files changed, 52 insertions(+), 62 deletions(-) diff --git a/src/examples/slickgrid/example1.tsx b/src/examples/slickgrid/example1.tsx index 74581702..1a5281dc 100644 --- a/src/examples/slickgrid/example1.tsx +++ b/src/examples/slickgrid/example1.tsx @@ -67,14 +67,15 @@ export default class Example1 extends React.Component { // copy the same Grid Options and Column Definitions to 2nd grid // but also add Pagination in this grid const gridOptions2: GridOption = { - ...gridOptions1, - ...{ - enablePagination: true, - pagination: { - pageSizes: [5, 10, 20, 25, 50], - pageSize: 5 - }, - } + gridHeight: 225, + gridWidth: 800, + enableAutoResize: false, + enableSorting: true, + enablePagination: true, + pagination: { + pageSizes: [5, 10, 20, 25, 50], + pageSize: 5 + }, }; this.setState((state: State) => ({ diff --git a/src/examples/slickgrid/example10.tsx b/src/examples/slickgrid/example10.tsx index f24289db..2f4f49ef 100644 --- a/src/examples/slickgrid/example10.tsx +++ b/src/examples/slickgrid/example10.tsx @@ -296,7 +296,7 @@ export default class Example10 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example10.tsx"> code diff --git a/src/examples/slickgrid/example11.tsx b/src/examples/slickgrid/example11.tsx index e25864f2..28983483 100644 --- a/src/examples/slickgrid/example11.tsx +++ b/src/examples/slickgrid/example11.tsx @@ -286,7 +286,7 @@ export default class Example11 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example11.tsx"> code diff --git a/src/examples/slickgrid/example12.tsx b/src/examples/slickgrid/example12.tsx index 675cbf9f..78be372b 100644 --- a/src/examples/slickgrid/example12.tsx +++ b/src/examples/slickgrid/example12.tsx @@ -282,7 +282,7 @@ class Example12 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example12.tsx"> code diff --git a/src/examples/slickgrid/example13.tsx b/src/examples/slickgrid/example13.tsx index be6b2133..737f403d 100644 --- a/src/examples/slickgrid/example13.tsx +++ b/src/examples/slickgrid/example13.tsx @@ -389,7 +389,7 @@ export default class Example13 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example13.tsx"> code diff --git a/src/examples/slickgrid/example14.tsx b/src/examples/slickgrid/example14.tsx index 5aade662..01c052e4 100644 --- a/src/examples/slickgrid/example14.tsx +++ b/src/examples/slickgrid/example14.tsx @@ -162,7 +162,7 @@ export default class Example14 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example14.tsx"> code diff --git a/src/examples/slickgrid/example15.tsx b/src/examples/slickgrid/example15.tsx index ad05bdc3..37e78558 100644 --- a/src/examples/slickgrid/example15.tsx +++ b/src/examples/slickgrid/example15.tsx @@ -276,7 +276,7 @@ class Example15 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example15.tsx"> code diff --git a/src/examples/slickgrid/example16.tsx b/src/examples/slickgrid/example16.tsx index e2175e9d..66f1de79 100644 --- a/src/examples/slickgrid/example16.tsx +++ b/src/examples/slickgrid/example16.tsx @@ -270,7 +270,7 @@ export default class Example16 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example16.tsx"> code diff --git a/src/examples/slickgrid/example17.tsx b/src/examples/slickgrid/example17.tsx index 78524399..faeb11b3 100644 --- a/src/examples/slickgrid/example17.tsx +++ b/src/examples/slickgrid/example17.tsx @@ -49,7 +49,7 @@ export default class Example17 extends React.Component { for Sorting, Filtering, etc...
  • - Soure code for this example is available here + Soure code for this example is available here
  • `; @@ -163,7 +163,7 @@ export default class Example17 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example17.tsx"> code diff --git a/src/examples/slickgrid/example18.tsx b/src/examples/slickgrid/example18.tsx index 35210b84..bc1f8b58 100644 --- a/src/examples/slickgrid/example18.tsx +++ b/src/examples/slickgrid/example18.tsx @@ -469,7 +469,7 @@ export default class Example18 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example18.tsx"> code diff --git a/src/examples/slickgrid/example19.tsx b/src/examples/slickgrid/example19.tsx index 495b9878..9a19538c 100644 --- a/src/examples/slickgrid/example19.tsx +++ b/src/examples/slickgrid/example19.tsx @@ -119,10 +119,10 @@ export default class Example19 extends React.Component { // expandableOverride: (row: number, dataContext: any, grid: SlickGrid) => (dataContext.id % 2 === 1), // // Preload View Template - // preloadView: PLATFORM.moduleName('examples/slickgrid/example19-preload.html'), + // preloadView: PLATFORM.moduleName('examples/example19-preload.html'), // // ViewModel Template to load when row detail data is ready - // viewModel: PLATFORM.moduleName('examples/slickgrid/example19-detail-view'), + // viewModel: PLATFORM.moduleName('examples/example19-detail-view'), // Optionally pass your Parent Component reference to your Child Component (row detail component) parent: this @@ -202,7 +202,7 @@ export default class Example19 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example19.tsx"> code diff --git a/src/examples/slickgrid/example2.tsx b/src/examples/slickgrid/example2.tsx index 27f1b71b..fa1f7999 100644 --- a/src/examples/slickgrid/example2.tsx +++ b/src/examples/slickgrid/example2.tsx @@ -43,7 +43,6 @@ const customEnableButtonFormatter: Formatter = (_row: number, _cell: n interface Props {} export default class Example2 extends React.Component { - isGridMounted = false; title = 'Example 2: Grid with Formatters'; subTitle = ` Grid with Custom and/or included Slickgrid Formatters (Wiki docs). @@ -69,18 +68,13 @@ export default class Example2 extends React.Component { columnDefinitions: [], dataset: [], }; - - // define the grid options & columns and then create the grid itself - this.defineGrid(); } componentDidMount() { document.title = this.title; - // populate the dataset once the grid is ready - this.setState((state: State, props: Props) => ({ - dataset: this.getData(), - })); + // define the grid options & columns and then create the grid itself + this.defineGrid(); } reactGridReady(reactGrid: ReactGridInstance) { @@ -144,12 +138,12 @@ export default class Example2 extends React.Component { // } }; - this.state = { + this.setState((state: State, props: Props) => ({ ...this.state, columnDefinitions : columns, gridOptions, - }; - this.isGridMounted = true; + dataset: this.getData(), + })); } // mock a dataset @@ -204,7 +198,7 @@ export default class Example2 extends React.Component { } render() { - return !this.isGridMounted ? '' : ( + return !this.state.gridOptions ? '' : (

    {this.title} diff --git a/src/examples/slickgrid/example20.tsx b/src/examples/slickgrid/example20.tsx index 4ea8f16d..6d3328a5 100644 --- a/src/examples/slickgrid/example20.tsx +++ b/src/examples/slickgrid/example20.tsx @@ -356,7 +356,7 @@ export default class Example20 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example20.tsx"> code diff --git a/src/examples/slickgrid/example21.tsx b/src/examples/slickgrid/example21.tsx index 447fae1f..b9556dd4 100644 --- a/src/examples/slickgrid/example21.tsx +++ b/src/examples/slickgrid/example21.tsx @@ -217,7 +217,7 @@ export default class Example21 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example21.tsx"> code diff --git a/src/examples/slickgrid/example22.tsx b/src/examples/slickgrid/example22.tsx index 1976adda..26451206 100644 --- a/src/examples/slickgrid/example22.tsx +++ b/src/examples/slickgrid/example22.tsx @@ -164,7 +164,7 @@ export default class Example22 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example22.tsx"> code diff --git a/src/examples/slickgrid/example23.tsx b/src/examples/slickgrid/example23.tsx index d0b06ebd..7eec7623 100644 --- a/src/examples/slickgrid/example23.tsx +++ b/src/examples/slickgrid/example23.tsx @@ -351,7 +351,7 @@ class Example23 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example23.tsx"> code diff --git a/src/examples/slickgrid/example24.tsx b/src/examples/slickgrid/example24.tsx index dda6d11b..d34bb526 100644 --- a/src/examples/slickgrid/example24.tsx +++ b/src/examples/slickgrid/example24.tsx @@ -490,7 +490,7 @@ class Example24 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example24.tsx"> code diff --git a/src/examples/slickgrid/example25.tsx b/src/examples/slickgrid/example25.tsx index 74d4de88..4e081d56 100644 --- a/src/examples/slickgrid/example25.tsx +++ b/src/examples/slickgrid/example25.tsx @@ -312,7 +312,7 @@ export default class Example25 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example25.tsx"> code diff --git a/src/examples/slickgrid/example26.tsx b/src/examples/slickgrid/example26.tsx index 201b37c8..371a53ff 100644 --- a/src/examples/slickgrid/example26.tsx +++ b/src/examples/slickgrid/example26.tsx @@ -377,7 +377,7 @@ class Example26 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example26.tsx"> code diff --git a/src/examples/slickgrid/example27.tsx b/src/examples/slickgrid/example27.tsx index e6da3621..9b140d24 100644 --- a/src/examples/slickgrid/example27.tsx +++ b/src/examples/slickgrid/example27.tsx @@ -372,7 +372,7 @@ export default class Example27 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example27.tsx"> code diff --git a/src/examples/slickgrid/example28.tsx b/src/examples/slickgrid/example28.tsx index 6e9bcda6..a8d477de 100644 --- a/src/examples/slickgrid/example28.tsx +++ b/src/examples/slickgrid/example28.tsx @@ -306,7 +306,7 @@ export default class Example28 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example28.tsx"> code diff --git a/src/examples/slickgrid/example29.tsx b/src/examples/slickgrid/example29.tsx index 5f0d2a20..df2e9fde 100644 --- a/src/examples/slickgrid/example29.tsx +++ b/src/examples/slickgrid/example29.tsx @@ -88,7 +88,7 @@ export default class Example29 extends React.Component { + href="https://github.com/ghiscoding/slickgrid-react/blob/master/src/examples/slickgrid/example29.tsx"> code diff --git a/src/examples/slickgrid/example3.tsx b/src/examples/slickgrid/example3.tsx index eb467f37..a42f395c 100644 --- a/src/examples/slickgrid/example3.tsx +++ b/src/examples/slickgrid/example3.tsx @@ -861,6 +861,7 @@ export default class Example3 extends React.Component {