From 02a106fdb247a883c3268c1c56b0ac5dd83d0853 Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Wed, 3 Aug 2022 01:02:01 -0400 Subject: [PATCH 1/2] fix(common): remove jquery-ui-dist from deps, use jquery-ui only - the dependency "jquery-ui-dist" was added for convenience (all-in-one) but wasn't managed by the jQuery team and it is now behind in version, it is missing a security patch and so this PR removes the use of that external "jquery-ui-dist", we should rely only on the official package "jquery-ui" which is maintained by the jQuery team --- packages/common/package.json | 1 - pnpm-lock.yaml | 8 -------- test/jest-pretest.ts | 3 ++- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/common/package.json b/packages/common/package.json index f876bcdd6..7275ca591 100644 --- a/packages/common/package.json +++ b/packages/common/package.json @@ -78,7 +78,6 @@ "flatpickr": "^4.6.13", "jquery": "^3.6.0", "jquery-ui": "^1.13.2", - "jquery-ui-dist": "^1.13.1", "moment-mini": "^2.24.0", "multiple-select-modified": "^1.3.17", "slickgrid": "^2.4.45", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index e6180c09e..8452619c8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -179,7 +179,6 @@ importers: flatpickr: ^4.6.13 jquery: ^3.6.0 jquery-ui: ^1.13.2 - jquery-ui-dist: ^1.13.1 moment-mini: ^2.24.0 multiple-select-modified: ^1.3.17 nodemon: ^2.0.19 @@ -198,7 +197,6 @@ importers: flatpickr: 4.6.13 jquery: 3.6.0 jquery-ui: 1.13.2 - jquery-ui-dist: 1.13.1 moment-mini: 2.24.0 multiple-select-modified: 1.3.17 slickgrid: 2.4.45 @@ -6387,12 +6385,6 @@ packages: engines: {node: '>=10'} dev: true - /jquery-ui-dist/1.13.1: - resolution: {integrity: sha512-Y711Pu4BRVrAlL58KSxX4ail74jaCJZaZcdNDLava+MgZeNwmVWmyYiK7KxyoJu1MB73eSunjJvYDbOuNrOA7w==} - dependencies: - jquery: 3.6.0 - dev: false - /jquery-ui/1.13.2: resolution: {integrity: sha512-wBZPnqWs5GaYJmo1Jj0k/mrSkzdQzKDwhXNtHKcBdAcKVxMM3KNYFq+iJ2i1rwiG53Z8M4mTn3Qxrm17uH1D4Q==} dependencies: diff --git a/test/jest-pretest.ts b/test/jest-pretest.ts index f505cbbdd..bccd2990e 100644 --- a/test/jest-pretest.ts +++ b/test/jest-pretest.ts @@ -7,7 +7,8 @@ import * as jQuery from 'jquery'; // (global as any).Storage = window.localStorage; (global as any).navigator = { userAgent: 'node.js' }; (global as any).Slick = (window as any).Slick = {}; -require('jquery-ui-dist/jquery-ui'); + +require('jquery-ui/dist/jquery-ui.js'); require('slickgrid/lib/jquery.event.drag-2.3.0'); require('slickgrid/slick.core'); require('slickgrid/slick.dataview'); From a2b15e7ec4b61ac93dc1bddfe6cfc3d8f49b3fb3 Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Wed, 3 Aug 2022 01:02:01 -0400 Subject: [PATCH 2/2] feat(common): remove jquery-ui-dist from deps, use jquery-ui only - the dependency "jquery-ui-dist" was added for convenience (all-in-one) but wasn't managed by the jQuery team and it is now behind in version, it is missing a security patch and so this PR removes the use of that external "jquery-ui-dist", we should rely only on the official package "jquery-ui" which is maintained by the jQuery team --- packages/common/package.json | 1 - pnpm-lock.yaml | 8 -------- test/jest-pretest.ts | 3 ++- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/common/package.json b/packages/common/package.json index f876bcdd6..7275ca591 100644 --- a/packages/common/package.json +++ b/packages/common/package.json @@ -78,7 +78,6 @@ "flatpickr": "^4.6.13", "jquery": "^3.6.0", "jquery-ui": "^1.13.2", - "jquery-ui-dist": "^1.13.1", "moment-mini": "^2.24.0", "multiple-select-modified": "^1.3.17", "slickgrid": "^2.4.45", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index e6180c09e..8452619c8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -179,7 +179,6 @@ importers: flatpickr: ^4.6.13 jquery: ^3.6.0 jquery-ui: ^1.13.2 - jquery-ui-dist: ^1.13.1 moment-mini: ^2.24.0 multiple-select-modified: ^1.3.17 nodemon: ^2.0.19 @@ -198,7 +197,6 @@ importers: flatpickr: 4.6.13 jquery: 3.6.0 jquery-ui: 1.13.2 - jquery-ui-dist: 1.13.1 moment-mini: 2.24.0 multiple-select-modified: 1.3.17 slickgrid: 2.4.45 @@ -6387,12 +6385,6 @@ packages: engines: {node: '>=10'} dev: true - /jquery-ui-dist/1.13.1: - resolution: {integrity: sha512-Y711Pu4BRVrAlL58KSxX4ail74jaCJZaZcdNDLava+MgZeNwmVWmyYiK7KxyoJu1MB73eSunjJvYDbOuNrOA7w==} - dependencies: - jquery: 3.6.0 - dev: false - /jquery-ui/1.13.2: resolution: {integrity: sha512-wBZPnqWs5GaYJmo1Jj0k/mrSkzdQzKDwhXNtHKcBdAcKVxMM3KNYFq+iJ2i1rwiG53Z8M4mTn3Qxrm17uH1D4Q==} dependencies: diff --git a/test/jest-pretest.ts b/test/jest-pretest.ts index f505cbbdd..bccd2990e 100644 --- a/test/jest-pretest.ts +++ b/test/jest-pretest.ts @@ -7,7 +7,8 @@ import * as jQuery from 'jquery'; // (global as any).Storage = window.localStorage; (global as any).navigator = { userAgent: 'node.js' }; (global as any).Slick = (window as any).Slick = {}; -require('jquery-ui-dist/jquery-ui'); + +require('jquery-ui/dist/jquery-ui.js'); require('slickgrid/lib/jquery.event.drag-2.3.0'); require('slickgrid/slick.core'); require('slickgrid/slick.dataview');