Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 #77

Merged
merged 14 commits into from
Apr 4, 2022
Merged

V1 #77

merged 14 commits into from
Apr 4, 2022

Conversation

ghodsizadeh
Copy link
Owner

Merge version 1 to master

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.86%.

Quality metrics Before After Change
Complexity 3.35 ⭐ 2.98 ⭐ -0.37 👍
Method Length 40.82 ⭐ 49.66 ⭐ 8.84 👎
Working memory 6.62 🙂 7.18 🙂 0.56 👎
Quality 75.12% 72.26% 🙂 -2.86% 👎
Other metrics Before After Change
Lines 371 571 200
Changed files Quality Before Quality After Quality Change
src/tehran_stocks/init.py 81.86% ⭐ 98.24% ⭐ 16.38% 👍
src/tehran_stocks/initializer.py 88.60% ⭐ 86.69% ⭐ -1.91% 👎
src/tehran_stocks/config/engine.py 91.52% ⭐ 61.98% 🙂 -29.54% 👎
src/tehran_stocks/download/names.py 61.97% 🙂 64.09% 🙂 2.12% 👍
src/tehran_stocks/download/price.py 63.01% 🙂 65.40% 🙂 2.39% 👍
src/tehran_stocks/models/create.py 98.83% ⭐ 98.83% ⭐ 0.00%
src/tehran_stocks/models/stocks.py 84.12% ⭐ 82.15% ⭐ -1.97% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/tehran_stocks/download/price.py update_stock_price 7 ⭐ 201 😞 11 😞 49.54% 😞 Try splitting into smaller methods. Extract out complex expressions
src/tehran_stocks/download/names.py get_stock_detail 9 🙂 217 ⛔ 7 🙂 55.03% 🙂 Try splitting into smaller methods
src/tehran_stocks/download/names.py fill_stock_table 5 ⭐ 135 😞 9 🙂 61.68% 🙂 Try splitting into smaller methods
src/tehran_stocks/models/stocks.py Stocks.get_instant_detail 0 ⭐ 151 😞 6 ⭐ 71.90% 🙂 Try splitting into smaller methods
src/tehran_stocks/download/price.py get_all_price 1 ⭐ 53 ⭐ 10 😞 75.01% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot mentioned this pull request Apr 4, 2022
@ghodsizadeh ghodsizadeh merged commit e89b469 into master Apr 4, 2022
ghodsizadeh added a commit that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant