Remove lsb #51
Remove lsb #51
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ghoneycutt-nfs", | |||
| "version": "1.8.0", | |||
| "version": "1.8.1", | |||
There was a problem hiding this comment.
Can you please unstage this and rebase your commit? It is good practice to not bump versions in a commit as the upstream maintainer will manage this as they might release other code before this.
|
retriggered travis. not sure why this was failing everywhere. |
| @@ -82,7 +82,7 @@ | |||
| case $::osfamily { | |||
| 'RedHat' : { | |||
| $default_pipefs_directory = 'UNSET' | |||
| case $::lsbmajdistrelease { | |||
| case $::operatingsystemmajrelease { | |||
There was a problem hiding this comment.
You'll need to update the corresponding spec tests for RedHat to use this fact.
|
@ghoneycutt I split this into two commits, one each for manifests and rspec test changes, let me know if you want those merged. Otherwise the rebase is ready for review. |
|
Hi @rnelson0, Thanks again! Please rebase into one commit as either commit is not mergeable by itself. I'm looking into why travis-ci is failing though. Submitted PR #52. After I get it merged, could you rebase against master and do your search/replace magic again :) Hopefully that fixes the travis-ci issue. |
|
Got it merged. |
|
@ghoneycutt Done, ready for review. |
|
Whoops, hold off, just saw the new tests you added in that PR. |
::nfs and ::nfs::idmap replace lsbmajdistrelease with operatingsystemajrelease for EL only. Rspec tests adjusted to use operatingsystemmajrelease in addition to lsbmajdistrelease. 100% pass.
|
@ghoneycutt OK really good to go this time! |
|
@rnelson0 great work! |
|
Released in v1.9.0 |
Resolves issue #41