Update spec tests (RTM) #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phil-Friderici
force-pushed
the
tests
branch
from
9661a59
to
7a4742c
Compare
This eleminates the special treatment that was needed for strings in tests.
Phil-Friderici
force-pushed
the
tests
branch
from
7a4742c
to
67829f7
Compare
|
Thanks @Phil-Friderici |
|
Noticed the WIP, let me know when this is ready for merge. |
Phil-Friderici
force-pushed
the
tests
branch
3 times, most recently
from
0f34cc7
to
8061194
Compare
Phil-Friderici
force-pushed
the
tests
branch
from
8061194
to
59b8f4b
Compare
|
Guess it would be clever to refactor code and template to always use arrays in the other cases as well: |
|
Is that commit saying I should Read The Manual? :> |
|
Thanks @Phil-Friderici |
|
sry 4 bd inglish, 4got the F |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the spec tests to follow the standard. Ensure all functionality is tested properly.