Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase solaris support #36

Merged
merged 4 commits into from
Oct 5, 2015
Merged

rebase solaris support #36

merged 4 commits into from
Oct 5, 2015

Conversation

Phil-Friderici
Copy link

to get #19 done before it have it's first birthday

First commit contains the old init_spec.rb to prove the patch is backward compatibility.

@@ -94,7 +274,6 @@
}
validate_bool($service_enable_real)

validate_absolute_path($logfile)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went down to line 523

@Phil-Friderici
Copy link
Author

The second commit contains the spec tests for the new functionality

@ghoneycutt ghoneycutt mentioned this pull request Aug 21, 2015
@Phil-Friderici
Copy link
Author

too bad Puppet v4 still throughs errors :(

@ghoneycutt
Copy link
Owner

This seems to be issues with the error messages that change in Puppet v4. I think you can just remove the carrots ^ from the error matching in the spec tests and this should pass.

@Phil-Friderici
Copy link
Author

Exactly, they sneaked back in with Solaris specific tests. Fixed it, should be passing now.

@Phil-Friderici
Copy link
Author

here we go, all back to green :)
@ghoneycutt have a nice weekend !

@ghoneycutt
Copy link
Owner

@Phil-Friderici Looks good. Could you use in your infrastructure on Solaris 10 and non-Solaris 10 systems to be sure we didn't miss anything?

@ghoneycutt
Copy link
Owner

Guten Feierabend! :)

@Phil-Friderici
Copy link
Author

Will verify/put it in production on monday morning. My local Solaris specialist is looking forward to give this a try :)

@Phil-Friderici
Copy link
Author

...still waiting for real life verification...

@ghoneycutt
Copy link
Owner

@Phil-Friderici No prob. When you say it's good, I'll merge :)

@Phil-Friderici
Copy link
Author

Real life testing showed that the source commit didn't took care for the Solaris specific package parameters. Adding/testing these at the very moment.

@Phil-Friderici
Copy link
Author

Now it works, but we need another rebase against master. As travis also stopped testing here, I'll create a new PR for that.

@ghoneycutt ghoneycutt merged commit 008fb1d into ghoneycutt:master Oct 5, 2015
@Phil-Friderici Phil-Friderici deleted the rebase_solaris_support branch October 5, 2015 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants