-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase solaris support #36
rebase solaris support #36
Conversation
| @@ -94,7 +274,6 @@ | |||
| } | |||
| validate_bool($service_enable_real) | |||
|
|
|||
| validate_absolute_path($logfile) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went down to line 523
|
The second commit contains the spec tests for the new functionality |
|
too bad Puppet v4 still throughs errors :( |
|
This seems to be issues with the error messages that change in Puppet v4. I think you can just remove the carrots |
|
Exactly, they sneaked back in with Solaris specific tests. Fixed it, should be passing now. |
|
here we go, all back to green :) |
|
@Phil-Friderici Looks good. Could you use in your infrastructure on Solaris 10 and non-Solaris 10 systems to be sure we didn't miss anything? |
|
Guten Feierabend! :) |
|
Will verify/put it in production on monday morning. My local Solaris specialist is looking forward to give this a try :) |
|
...still waiting for real life verification... |
|
@Phil-Friderici No prob. When you say it's good, I'll merge :) |
|
Real life testing showed that the source commit didn't took care for the Solaris specific package parameters. Adding/testing these at the very moment. |
|
Now it works, but we need another rebase against master. As travis also stopped testing here, I'll create a new PR for that. |
to get #19 done before it have it's first birthday
First commit contains the old
init_spec.rbto prove the patch is backward compatibility.