Add rubocop support to lint spec tests and make recommended changes

[ghoneycutt]

No description provided.

[Phil-Friderici]

@ghoneycutt that looks very interesting. Only drawback is that the tests runs much longer with rubycop :(

[ghoneycutt]

@Phil-Friderici Seems about the same as this test which was pre-rubocop

https://travis-ci.org/ghoneycutt/puppet-module-nscd/builds/86252151

The rubocop test run itself runs very fast and is only done with the newest puppet version of each ruby version (except 1.8.7)

Am I missing something?

[ghoneycutt]

If nothing else, this taught me about using %r{/foo/bar} instead of /\/foo\/bar/ :)

[Phil-Friderici]

Now that I have used rubocop more often I am starting to like it. It actualy helps to find errors and enhance style.

Do you think this is something to get mandatory (activated at Travis) at a later point ?

[ghoneycutt]

Already is :)

https://github.com/ghoneycutt/puppet-module-nscd/blob/master/.travis.yml#L25