Support SLES 15 #43
Support SLES 15 #43
Conversation
manifests/init.pp
Outdated
| } elsif $facts['os']['family'] == 'Suse' and !($facts['os']['release']['major'] in ['11','12']) { | ||
| fail("osfamily Suse's os.release.major is <${::facts['os']['release']['major']}> and must be 11 or 12") | ||
| } elsif $facts['os']['family'] == 'Suse' and !($facts['os']['release']['major'] in ['11','12','15']) { | ||
| fail("osfamily Suse's os.release.major is <${::facts['os']['release']['major']}> and must be 11, 12 and 15") |
There was a problem hiding this comment.
Thanks @anders-larsson for your contribution.
For the sentence to make sense it should end with "11, 12 or 15"
Would you mind making that small change and squashing/rebasing and I'll get this merged.
There was a problem hiding this comment.
Oh. Yes ofcouse. It should definitely be 'or' there.
|
Hi, The README should also be updated https://github.com/ghoneycutt/puppet-module-rpcbind/blob/master/README.md#limitations |
|
@ghoneycutt Thanks for your fast review! I'll fix it tomorrow. Do you want me to add it to travis as well? Right now it doesn't appear any Suse entries are tested.
Thanks again! |
|
It doesn't appear that we add the versions to We do not have acceptance testing for Suse as I don't believe there are Docker images for the specific versions. You are more than welcome to add them, though not at all required. If you are excited to play with that, suggest doing it in another pull request so we can get this merged. |
anders-larsson
force-pushed
the
support_sles15
branch
from
c5c5b27
to
a67de4a
Compare
|
I've updated the pull request with the requested changes. |
|
Thanks @anders-larsson Released in v2.4.0 |
Adds support for SLES 15.