Support Ubuntu 20.04 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-larsson
force-pushed
the
support_ubuntu2004
branch
3 times, most recently
from
13070fd
to
68c9d51
Compare
|
It appears PuppetLabs has decided not to provide a puppet5 package for 20.04. OK to remove Puppet 5 from Ubuntu 20.04 tests? |
|
@anders-larsson Awesome! Thank you! Looks like Travis had a time out with one of the tests. Restarting and once it passes, this is good to be merged. |
ghoneycutt
approved these changes
Jul 15, 2020
|
Aha.. that was the error, because the packages do not exist. Yes, go ahead and remove from Travis and leave a comment saying that Ubuntu 20.04 is not supported on Puppet 5. |
|
Where do you want this comment added? I'll fix it tomorrow. Thanks. |
|
Hi, Just add it to travis in place of the puppet5 section you are removing. |
anders-larsson
force-pushed
the
support_ubuntu2004
branch
from
68c9d51
to
8c8f458
Compare
|
@ghoneycutt Pull request ready for another review btw :) |
|
Brilliant! Thanks @anders-larsson |
|
Released in v2.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.