Support puppet v3 with future parser and puppet v4

[ghoneycutt]

No description provided.

[ghoneycutt]

@Phil-Friderici Have you seen this recently? Failing with strict variables because of operatingsystemmajrelease. The version of Facter looks good.. problem with the travis container?

[Phil-Friderici]

The failing test [1] sets lsbmajdistrelease but needed [2] operatingsystemmajrelease is missing.

[1] https://github.com/ghoneycutt/puppet-module-timezone/blob/puppet3_future_and_puppet4/spec/classes/init_spec.rb#L90-L98
[2] https://github.com/ghoneycutt/puppet-module-timezone/blob/master/manifests/init.pp#L40-L43

Same is true for for the arc parameter tests.

Strict variables tests are not forgiving anymore like in the past. If a variable is used but not defined it fails since the introduction of Puppet 4.4. Before that, a variable called but not defined was handled like undef.

[ghoneycutt]

Thanks @Phil-Friderici !

[Phil-Friderici]

tests fails because of missmatching code vs specs

https://github.com/ghoneycutt/puppet-module-timezone/blob/master/manifests/init.pp#L43

Guess that you need to remove the colon from release variable here
https://github.com/ghoneycutt/puppet-module-timezone/blob/master/spec/classes/init_spec.rb#L21

never mind, now I see you did already :)

[Phil-Friderici]

well, you need to move these line into the if/else statement:

https://github.com/ghoneycutt/puppet-module-timezone/blob/puppet3_future_and_puppet4/spec/classes/init_spec.rb#L32-L35

[Phil-Friderici]

took over the work in #3