Add support for Puppet 5 & 6 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Dec 11, 2018
Rakefile
Outdated
| end | ||
| end | ||
|
|
||
| desc 'Validate that README.md documents all parameters for each class' |
There was a problem hiding this comment.
please remove this validate_readme task as we don't need it and the script doesn't exist
There was a problem hiding this comment.
Sorry, that obviously sneaked in while copy/pasting. Removed it.
added 3 commits
December 11, 2018 07:52
Deprecation Warnings: puppetlabs_spec_helper: defaults `mock_with` to `:mocha`. See https://github.com/puppetlabs/puppetlabs_spec_helper#mock_with to choose a sensible value for you
Phil-Friderici
force-pushed
the
puppet6
branch
from
fd94c4f
to
6220496
Compare
|
Unsure if Ruby templates are actually verified. In the past we had these lines in Rakefile: Is there some template testing magic that I am not aware of ? |
|
Thanks @Phil-Friderici Released in v2.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.