Skip to content

Commit

Permalink
Update Adblock Plus to use npm package (#2142)
Browse files Browse the repository at this point in the history
  • Loading branch information
mjethani authored Aug 10, 2021
1 parent a0c57f3 commit 28f042a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "packages/adblocker-benchmarks/blockers/adblockpluscore"]
path = packages/adblocker-benchmarks/blockers/adblockpluscore
url = https://github.com/adblockplus/adblockpluscore
8 changes: 2 additions & 6 deletions packages/adblocker-benchmarks/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,13 @@ requests.json:
ubo-core: ./node_modules/@gorhill/ubo-core

./node_modules/adblockpluscore:
cp -R ./blockers/adblockpluscore ./node_modules
npm install --no-save adblockpluscore
cp ./blockers/adblockpluscore-index.js ./node_modules/adblockpluscore/lib
npx rollup ./node_modules/adblockpluscore/lib/adblockpluscore-index.js \
--file ./node_modules/adblockpluscore/lib/bundle.min.cjs --format cjs \
--plugin commonjs --plugin json --plugin terser --output.exports named

./blockers/adblockpluscore/.git:
git submodule update --recursive --depth 1 --init blockers/adblockpluscore

adblockpluscore: ./blockers/adblockpluscore/.git ./node_modules/adblockpluscore
adblockpluscore: ./node_modules/adblockpluscore

./node_modules/@adguard/tsurlfilter:
npm install --no-save @adguard/tsurlfilter
Expand Down Expand Up @@ -94,4 +91,3 @@ run: deps url tldts cliqz ublock adblockplus brave adblockfast
clean:
rm -f requests.json
npm uninstall @adguard/tsurlfilter adblockpluscore @gorhill/ubo-core adblock-rs
git submodule deinit --all
1 change: 0 additions & 1 deletion packages/adblocker-benchmarks/blockers/adblockpluscore
Submodule adblockpluscore deleted from ebfc7b
1 change: 1 addition & 0 deletions packages/adblocker-benchmarks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"peerDependencies": {
"@adguard/tsurlfilter": "^0.5.24",
"adblock-rs": "^0.3.15",
"adblockpluscore": "^0.3.1",
"@gorhill/ubo-core": "^0.1.7"
},
"dependencies": {
Expand Down

0 comments on commit 28f042a

Please sign in to comment.