This repository has been archived by the owner. It is now read-only.
Native ActionSheet implementation for 3dots menu, and MyOffrz integration #12
Conversation
| @@ -347,6 +347,7 @@ class BrowserViewController: UIViewController { | |||
| urlBar = URLBarView() | |||
| */ | |||
| urlBar = CliqzURLBar() | |||
| NotificationCenter.default.addObserver(self, selector: #selector(urlBarDidPressPageCliqzOptions), name: URLBarDidPressPageOptionsNotification, object: nil) | |||
mahmoud-adam85
Mar 22, 2018
Contributor
could you fix the indentation of this line
could you fix the indentation of this line
naira-cliqz
Mar 22, 2018
Author
Contributor
The indentation is fine, github messes up...
The indentation is fine, github messes up...
Cliqz/URLBar/CliqzURLBar.swift
Outdated
| @@ -145,6 +155,9 @@ class CliqzURLBar: URLBarView { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| override func tabLocationViewDidTapPageOptions(_ tabLocationView: TabLocationView, from button: UIButton) { self.delegate?.urlBarDidPressCliqzPageOptions(self, from: tabLocationView.pageOptionsButton) | |||
mahmoud-adam85
Mar 22, 2018
Contributor
could you add new line to method body
could you add new line to method body
naira-cliqz
Mar 22, 2018
Author
Contributor
This one is fixed
This one is fixed
mahmoud-adam85
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.